allow set prv.key via LoRa for easier repeater id collision fixup#1054
Closed
recrof wants to merge 1 commit intomeshcore-dev:devfrom
Closed
allow set prv.key via LoRa for easier repeater id collision fixup#1054recrof wants to merge 1 commit intomeshcore-dev:devfrom
set prv.key via LoRa for easier repeater id collision fixup#1054recrof wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
Member
|
I just realised that changing the private key (ie. self_id) invalidates the ACL. For performance reasons, I decided to persist the shared_secret for each entry in the ACL. |
Member
Author
|
@ripplebiz does that mean you'll first implement the required changes before this PR can be merged? |
recrof
changed the title
set prv.key via LoRa for easier collision fixupset prv.key via LoRa for easier repeater id collision fixup
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote-setting private key is crucial when operator needs to change public key of the node because of ID collision.
In case of repeater breach: setting different private key by the attacker has low gain - owner will be notified that the public key was changed as soon as repeater adverts again.