Add a watchdog for nRF52 based repeaters#2405
Open
winnieXY wants to merge 3 commits intomeshcore-dev:devfrom
Open
Add a watchdog for nRF52 based repeaters#2405winnieXY wants to merge 3 commits intomeshcore-dev:devfrom
winnieXY wants to merge 3 commits intomeshcore-dev:devfrom
Conversation
…n can be easier added for other platforms later
Use #ifdef just for setting/getting - this can be removed if the watchdog is implemented on the other platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I've created a watchdog which can be enabled via cli and defaults to off for nRF52 based repeaters. For all other archs are stubs available which are (currently) doing nothing - so there needs to be some code implemented later for esp32 and co.
This patch would mitigate together with the atomic write patch (#2386) issues with failed writes on the internal flash off the p1 - see #2283
In order to test it i provoked a HardFault on the repeater - it came up after 10 seconds again:
This watchdog would e.g. also fix this bug #2320 without adding unnecessary reboots on the devices. For debugging or testing the watchdog can be disabled by setting the timeout to 0 (which is also the default).
@oltaco: could you please review the patches?