fix: skip GPS auto-detect on SenseCAP Solar (P1 Pro)#2409
Open
syssi wants to merge 1 commit intomeshcore-dev:devfrom
Open
fix: skip GPS auto-detect on SenseCAP Solar (P1 Pro)#2409syssi wants to merge 1 commit intomeshcore-dev:devfrom
syssi wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GPS detection in
EnvironmentSensorManager::initBasicGPS()waits only 1 second before checkingSerial1.available() > 0. Cold-starting GPS modules commonly need 2–5 seconds before outputting NMEA sentences. On the SenseCAP Solar (P1 Pro) the GPS doesn't respond within that window, sogps_detectedstaysfalse, hiding all GPS CLI commands and preventing GPS time sync entirely. See #2258 for the underlying issue affecting most GPS-equipped variants.Workaround
Sets
ENV_SKIP_GPS_DETECT=1in the SenseCAP Solar build flags, bypassing the unreliable detection check and marking the GPS as present unconditionally. This is consistent with how other affected variants are handled (LilyGo TBeam 1W, ThinkNode M1/M5, Station G2).Note
This is a stopgap until #2258 is resolved with a proper fix in
initBasicGPS()(e.g. a retry loop up to 5 seconds). Once that lands, this flag becomes redundant.