GRO-415 [3/2] new new pricing nav updates#1169
Merged
Merged
Conversation
bpander
changed the title
bpander
force-pushed
the
gro-415-new-new-pricing-nav
branch
from
fe4a493 to
2b20739
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How to verify
JEKYLL_ENV=production ./script/buildand serve it somehow e.g.serve _site -p 4000http://localhost:4000/docs/latestdocument.documentElement.setAttribute("data-pricing-variant", "new")-> pricing link should turn to a dropdown (verifies correct nav header html is used)script/_data/bin/shared-chrome.jsshould only change the generated_at propertyYou can also test the a/b test on http://metabase.local:4000/docs/latest