Fujitsu support - #85
Open
izvyk wants to merge 33 commits into
Open
Conversation
Open
This was referenced Feb 5, 2026
simcod
reviewed
Feb 5, 2026
izvyk
force-pushed
the
83-fujitsu-support
branch
from
February 16, 2026 15:26
7bc6c6c to
61d0c75
Compare
…ed when merged to the upstream)
Contributor
|
Last commit can now be replaced with latest release. Gofish v0.21.1 includes the Reset fix. |
Contributor
|
Final tests verified:
# BootSourceOverride for machine creation
{
"BootSourceOverrideEnabled": "Continuous",
"BootSourceOverrideTarget": "Hdd"
}# BootSourceOverride for machine deletion
{
"BootSourceOverrideEnabled": "Continuous",
"BootSourceOverrideTarget": "Pxe"
} |
simcod
marked this pull request as ready for review
April 15, 2026 14:34
majst01
reviewed
May 30, 2026
Comment on lines
394
to
584
| @@ -519,7 +544,7 @@ func (c *APIClient) SetBootOrder(entries []*schemas.BootOption) error { | |||
| return err | |||
| } | |||
| c.addHeadersAndAuth(req) | |||
| resp, err := c.Do(req) | |||
| resp, err := c.doWithETag(req) | |||
| _ = resp.Body.Close() | |||
| if err != nil { | |||
| return fmt.Errorf("unable to set boot order: %w", err) | |||
| @@ -554,7 +579,7 @@ func (c *APIClient) UpdateFirmware(url string) error { | |||
| } | |||
| c.addHeadersAndAuth(req) | |||
|
|
|||
| resp, err := c.Do(req) | |||
| resp, err := c.doWithETag(req) | |||
| if err != nil { | |||
| return fmt.Errorf("unable to trigger update: %w", err) | |||
Contributor
There was a problem hiding this comment.
If this still works with Dell and Supermicro, this PR is nice ! Good Job @izvyk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83