build: fix CI infrastructure (Trivy action bump + FedRAMP test URL) - #277
Conversation
Upgrade the Trivy security scanner action from v0.33.1 to v0.35.0. The v0.33.1 version's Trivy installation step has been failing in CI since February 2026 (exit code 1 immediately after fetching the Trivy binary version), blocking all PRs regardless of code changes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated the Trivy GitHub Action pin to a different commit (v0.35.0) and changed a test resource URI in OscalValidationTest to validate a different OSCAL FedRAMP XML profile; no other workflow logic or exported API changes were made. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The GSA/fedramp-automation repository is no longer publicly accessible, causing OscalValidationTest.testValidateOscalProfileXml to fail with FileNotFound on every CI run. Point the test at the equivalent profile in the OSCAL-Foundation/fedramp-automation repository (rev5 MODERATE baseline), which is the current home for the FedRAMP automation work.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/test/java/dev/metaschema/oscal/lib/validation/OscalValidationTest.java`:
- Line 83: In OscalValidationTest update the external URIs that use
"refs/heads/master" and "refs/heads/main" (the FedRAMP profile and OSCAL
metaschema references found in the test URI strings) to point to immutable
commit SHAs or replace them with checked-in fixture paths; locate the URI
literals in the test (search for the strings "refs/heads/master" and
"refs/heads/main" in OscalValidationTest) and change them to fixed commit SHA
URLs or to local test resources so CI tests become deterministic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 43ff219e-c163-4939-811f-3b71e74e890e
📒 Files selected for processing (1)
src/test/java/dev/metaschema/oscal/lib/validation/OscalValidationTest.java
Pin the FedRAMP profile URL to a specific commit SHA rather than the master branch ref, so the test is not sensitive to upstream changes.
e86b03b
into
metaschema-framework:develop
Summary
Two CI infrastructure fixes that together unblock all PR builds:
aquasecurity/trivy-actionfrom v0.33.1 to v0.35.0 — The v0.33.1 pinned version's Trivy install step has been failing in CI since 2026-02-10 (exit code 1 immediately after fetching the Trivy binary), blocking every PR regardless of code content.OscalValidationTest.testValidateOscalProfileXml— TheGSA/fedramp-automationrepository is no longer publicly accessible, causing the test to fail withFileNotFoundon every CI run. Point it at the equivalent profile inOSCAL-Foundation/fedramp-automation(rev5 MODERATE baseline), the current home for FedRAMP automation work.Test plan
Summary by CodeRabbit
Chores
Tests