Add Vitest unit tests for critical business logic#75
Open
tommy-mor wants to merge 1 commit into
Open
Conversation
Stand up Vitest with CI coverage and 86 unit tests across auth, scoring, map bans, passwords, redirects, rate limits, and draft validation. Extract map ban and match scoring helpers so they can be tested without loading Prisma.
tommy-mor
marked this pull request as ready for review
July 26, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Vitest and a first suite of 86 unit tests covering the highest-risk pure logic paths (no Playwright / no DB integration).
What
bun run test/test:watchmapBanLogic.ts(ban/pick turn machine)matchScoring.ts(winner tally, manage-match checks, score validation)redirect.ts(open-redirect sanitization)maxmemsoN=32768hashing works under OpenSSL’s default memory ceilingCoverage
Auth guards, match scoring (incl. playoff arena tallies), map ban BO3/5/7 sequences, password hash/verify (versioned + legacy, no plaintext fallback), redirect sanitization, rate limiting, form/Zod helpers, Steam ID conversions, tournament draft validation, bracket topology helpers.
Intentionally out of scope
Test plan
bun run test— 14 files, 86 passingbun run format/check/boundary-check/knip