fix(web-components): expose toggle checked state to screen readers - #4603
fix(web-components): expose toggle checked state to screen readers#4603sylvesterkaczmarek wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Welcome 👋
Welcome to the ic-ui-kit repo, thank you for submitting a pull request!
How to contribute
Please read our CONTRIBUTING.md, which explains our ways of working and guidelines for contributions.
Code of Conduct
We'd appreciate it if you could read and abide by our Code of Conduct, as we wish to foster an inclusive and respectful community.
Targeting your pull request
We use develop rather than main as the base for contributions - please make sure your PR is targeting develop.
Signing the CLA
We require all contributors to sign our Contributor License Agreement (CLA) before we can accept a contribution. If you are contributing on behalf of an organization please follow your organization's policies in signing CLAs.
Associated issue
Please make sure that your pull request has an issue open - this allows us to keep track of changes made and offer support where needed.
0795646 to
e3b71bd
Compare
|
Hi @sylvesterkaczmarek, looks like this pull request is just failing prettier checks, please could you run |
|
Thanks for flagging this. I've applied the formatting fix and pushed the update. |
|
Hi, sorry it's now failing some unit tests. One of them appears to be a snapshot that can be regenerated, but another looks like an unexpected change to functionality. Would you be able to take a look into it? |
|
Thanks for flagging this. I’ve pushed the Prettier-only formatting fix. The new workflow run is currently marked “action required”, so it looks like it now just needs maintainer approval before the checks can run. |
923f9cd to
a8b47fb
Compare
|
Please rebase this branch |
475a74e to
5393091
Compare
Propagate role and aria-checked from the ic-button host to its native focus target so screen readers can announce toggle state changes.
5393091 to
089095c
Compare
Summary of the changes
Fixes the accessibility semantics for toggle items in
ic-popover-menu.The toggle
roleandaria-checkedstate were applied to theic-buttonhost while keyboard focus and screen-reader interaction occur on its native button. This change forwards those semantics to the native focus target and keepsaria-checkedsynchronized as the item is toggled.Regression coverage now verifies both unchecked and checked states on the focusable native button, with the snapshot updated for the corrected accessible DOM.
Related issue
Closes #4518
Validation