fix(web-components): truncate long breadcrumb titles on reflow - #4605
fix(web-components): truncate long breadcrumb titles on reflow#4605sylvesterkaczmarek wants to merge 1 commit into
Conversation
|
Sylvester Kaczmarek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
0795646 to
e3b71bd
Compare
|
Hi @sylvesterkaczmarek, looks like this change is causing the unit and Cypress visual regression tests to fail. For the unit tests if you could regenerate the snapshot file then that should fix them. Thank you |
|
Thanks for spotting those. I've regenerated the snapshot and restored the breadcrumb title typography to match develop. |
|
Thanks for making those updates @sylvesterkaczmarek. Looks like it's still failing 8 breadcrumb visual tests by 0.001% difference. It might be a case that they need regenerating instead, would you be able to update the images? Also would you be able to squash all of the web-components commits into one like you've done on other pull requests? Thank you |
|
Thanks for the guidance. I’ve pushed the typography fix and updated the affected snapshots. The new workflow run is currently marked “action required”, so it looks like it now just needs maintainer approval before the checks can run. |
923f9cd to
a8b47fb
Compare
|
Please rebase this branch |
Allow breadcrumb flex items to shrink and truncate long page titles with an ellipsis, preserve the existing typography, and update affected snapshots. mi6#4458
Summary of the changes
Prevents very long breadcrumb page titles from forcing horizontal scrolling in narrow layouts.
The breadcrumb and its nested flex containers can now shrink below their intrinsic content width. Page titles are rendered in a dedicated
page-titlespan and use overflow clipping with an ellipsis, while chevrons and icons retain their fixed size. The full title remains present in the DOM.Snapshots are updated for linked and current-page breadcrumb variants.
Related issue
Closes #4458
Validation