feat(web-components): support flex item dividers - #4612
feat(web-components): support flex item dividers#4612sylvesterkaczmarek wants to merge 2 commits into
Conversation
GCHQ-Developer-530
left a comment
There was a problem hiding this comment.
Hi @sylvesterkaczmarek, thanks for making these changes. Just a few comments from me.
Please could you squash all of your web-components commits into one?
Also I think this change would benefit from a Cypress visual regression test so that we can see the prop in action. Would you be able to add one and commit it with the react scope?
Additionally please could you add a story to demonstrate this change both for web-components and react?
Thank you
0795646 to
e3b71bd
Compare
|
@GCHQ-Developer-530 Thanks. I've squashed the web-components changes into one commit, added a React-scoped Cypress visual regression test with its generated baseline, and added flex item stories for both Web Components and React. |
|
Hi, thanks for the contribution. We generally keep Cypress tests in one file per component. |
e3b71bd to
1b185ad
Compare
|
Thanks for the guidance. I've moved the Cypress coverage into the existing IcDivider test file and moved the baseline to match. The web-components and React changes remain separated by scope. The new Actions runs are currently waiting for maintainer approval. |
923f9cd to
a8b47fb
Compare
|
Please rebase this branch |
0aec5e3 to
cc9133f
Compare
cc9133f to
1a4a6ac
Compare
Summary of the changes
Add a
flexItemprop toIcDividerso vertical dividers can stretch correctly when used as children of flex containers without an explicit height.When enabled on a vertical divider, the host uses
align-self: stretchand the divider line and labelled segments grow to fill the available height. Existing behaviour remains unchanged by default.A focused unit test verifies the prop applies the flex-item state.
Related issue
Closes #4075
Validation
flexItemdefaults tofalse