Skip to content

fix(web-components): #4280 add toggle button tooltips - #4624

Open
sylvesterkaczmarek wants to merge 1 commit into
mi6:developfrom
sylvesterkaczmarek:fix/4280-toggle-button-tooltip
Open

fix(web-components): #4280 add toggle button tooltips#4624
sylvesterkaczmarek wants to merge 1 commit into
mi6:developfrom
sylvesterkaczmarek:fix/4280-toggle-button-tooltip

Conversation

@sylvesterkaczmarek

@sylvesterkaczmarek sylvesterkaczmarek commented Aug 20, 2026

Copy link
Copy Markdown

Summary of the changes

Add standard ICDS tooltips to non-icon IcToggleButton components when a title is provided.

  • forwards the host title to the underlying IcButton
  • removes the browser-native title from the toggle-button host
  • preserves existing icon-toggle tooltip behaviour
  • preserves tooltipPlacement
  • adds unit coverage
  • adds Cypress visual regression and accessibility coverage

Related issue

Closes #4280

GCHQ-Developer-530
GCHQ-Developer-530 requested changes Aug 21, 2026
View reviewed changes
Comment thread packages/react/src/component-tests/IcToggleButton/IcToggleButtonTooltip.cy.tsx Outdated
Comment thread ...s/web-components/src/components/ic-toggle-button/test/basic/ic-toggle-button-tooltip.spec.ts Outdated
@GCHQ-Developer-530

GCHQ-Developer-530 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Please rebase this branch

@GCHQ-Developer-530
GCHQ-Developer-530 force-pushed the fix/4280-toggle-button-tooltip branch from 09d7ab6 to fa5a8eb Compare August 25, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GCHQ-Developer-530 GCHQ-Developer-530 GCHQ-Developer-530 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sylvesterkaczmarek @GCHQ-Developer-530