fix(web-components): #4451 preserve dialog content semantics - #4625
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
fix(web-components): #4451 preserve dialog content semantics#4625sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
GCHQ-Developer-299
force-pushed
the
develop
branch
from
August 21, 2026 10:18
98e9bcd to
29ff894
Compare
GCHQ-Developer-530
requested changes
Aug 24, 2026
Contributor
There was a problem hiding this comment.
Looks like this file has a prettier error, please can you run npm run prettier:fix to fix it?
Author
There was a problem hiding this comment.
Fixed. Reformatted the Cypress changes and rebuilt the branch cleanly on current develop.
GCHQ-Developer-299
force-pushed
the
develop
branch
from
August 24, 2026 11:55
923f9cd to
a8b47fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Remove the forced
aria-describedbyfromIcDialog's native dialog element so structured slotted content is not flattened into a single screen-reader description.This keeps
aria-labelledbyfor the dialog heading/label and allows links and other semantic content to remain navigable.Added:
aria-describedbyis omitted, heading labelling is preserved, the slotted link remains focusable, and axe passesThis follows WAI-ARIA APG guidance to omit
aria-describedbywhen dialog content contains semantic structures that need to be navigated.Related issue
Closes #4451