fix(web-components): recalculate navigation group height on expand - #4651
Merged
GCHQ-Developer-299 merged 1 commit intoSep 1, 2026
Conversation
GCHQ-Developer-530
force-pushed
the
fix/3901-navigation-group-height-recalculation
branch
from
August 28, 2026 14:10
7cd3e50 to
d72509d
Compare
Measure grouped navigation item heights after layout settles and remeasure on the first expanded/collapsed transition so wrapped collapsed labels do not leave stale spacing. .mi6#3901
GCHQ-Developer-530
force-pushed
the
fix/3901-navigation-group-height-recalculation
branch
from
August 28, 2026 14:38
d72509d to
e0bb239
Compare
GCHQ-Developer-530
approved these changes
Aug 28, 2026
GCHQ-Developer-530
left a comment
Contributor
There was a problem hiding this comment.
Tested using playground, looks good to me!
For other reviewers:
The bug -
Screen.Recording.2026-08-28.at.16.14.52.mov
After this fix -
Screen.Recording.2026-08-28.at.16.14.16.mov
GCHQ-Developer-299
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Fixes grouped navigation item spacing when
collapsedIconLabelscauses taller items in a collapsed side navigation and the side navigation is then expanded.IcNavigationGroupcached the sum of child item heights while collapsed. On the first transition to the expanded state, the cache-miss path waited for layout to settle but then reused the old cached total instead of measuring the now-expanded items. This left the grouped-links wrapper at the collapsed height.This change:
No public API changes.
Related issue
Closes #3901
Testing
web-componentscommit.develop.Full upstream CI will run when the PR is opened.