fix(web-components): #4657 show select icon when disabled - #4667
fix(web-components): #4657 show select icon when disabled#4667lKolabrodl wants to merge 1 commit into
Conversation
Render the icon slot for disabled selects and apply the existing disabled icon colour token. Closes mi6#4657
There was a problem hiding this comment.
Welcome 👋
Welcome to the ic-ui-kit repo, thank you for submitting a pull request!
How to contribute
Please read our CONTRIBUTING.md, which explains our ways of working and guidelines for contributions.
Code of Conduct
We'd appreciate it if you could read and abide by our Code of Conduct, as we wish to foster an inclusive and respectful community.
Targeting your pull request
We use develop rather than main as the base for contributions - please make sure your PR is targeting develop.
Signing the CLA
We require all contributors to sign our Contributor License Agreement (CLA) before we can accept a contribution. If you are contributing on behalf of an organization please follow your organization's policies in signing CLAs.
Associated issue
Please make sure that your pull request has an issue open - this allows us to keep track of changes made and offer support where needed.
Summary of the changes
Keeps the
ic-selecticon visible when the component is disabled.The icon slot is now rendered for disabled selects and uses the existing
--ic-atoms-input-select-content-icon-disabledtoken, so the icon is greyed out as expected.No public API changes.
Related issue
Fixes #4657
Testing
ic-selectis disabled.showIconanddisabledenabled.Checklist
General
Testing
Accessibility and additional checks
The change restores an existing decorative icon and uses the existing disabled colour token. It does not change interaction, layout, motion, content, public API, roles, or ARIA attributes.
Manual assistive technology, zoom, high contrast, cross-browser, performance, and SSR/SSG checks were not run locally.