Skip to content

fix(web-components): #4657 show select icon when disabled - #4667

Open
lKolabrodl wants to merge 1 commit into
mi6:developfrom
lKolabrodl:fix/4657-ic-select-disabled-icon
Open

fix(web-components): #4657 show select icon when disabled#4667
lKolabrodl wants to merge 1 commit into
mi6:developfrom
lKolabrodl:fix/4657-ic-select-disabled-icon

Conversation

@lKolabrodl

Copy link
Copy Markdown

Summary of the changes

Keeps the ic-select icon visible when the component is disabled.

The icon slot is now rendered for disabled selects and uses the existing --ic-atoms-input-select-content-icon-disabled token, so the icon is greyed out as expected.

No public API changes.

Related issue

Fixes #4657

Testing

  • Added a unit regression test that verifies the icon slot is rendered when ic-select is disabled.
  • Verified the fix in the Web Components Storybook playground with showIcon and disabled enabled.
  • Jest summary: 67 test suites, 1,162 tests, and 656 snapshots passed.
  • Prettier and Stylelint passed.
  • ESLint completed with 0 errors (existing warnings only).

Checklist

General

  • Changes to the docs package checked; no documentation update is required.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit test added; no visual regression baseline was required.
  • Playground story checked; no story or prop changes are required.
  • The disabled appearance was checked against the expected behaviour in the issue.

Accessibility and additional checks

The change restores an existing decorative icon and uses the existing disabled colour token. It does not change interaction, layout, motion, content, public API, roles, or ARIA attributes.

Manual assistive technology, zoom, high contrast, cross-browser, performance, and SSR/SSG checks were not run locally.

Render the icon slot for disabled selects and apply the existing disabled icon colour token.

Closes mi6#4657
@CLAassistant

CLAassistant commented Sep 3, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome 👋

Welcome to the ic-ui-kit repo, thank you for submitting a pull request!

How to contribute

Please read our CONTRIBUTING.md, which explains our ways of working and guidelines for contributions.

Code of Conduct

We'd appreciate it if you could read and abide by our Code of Conduct, as we wish to foster an inclusive and respectful community.

Targeting your pull request

We use develop rather than main as the base for contributions - please make sure your PR is targeting develop.

Signing the CLA

We require all contributors to sign our Contributor License Agreement (CLA) before we can accept a contribution. If you are contributing on behalf of an organization please follow your organization's policies in signing CLAs.

Associated issue

Please make sure that your pull request has an issue open - this allows us to keep track of changes made and offer support where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants