improvements - #789
Merged
Merged
Conversation
The MCP budget type enum matched atoms while the value arrives from JSON as a string, so every create or update naming a type was refused as Invalid params. An end-to-end server test now goes through the transport that validates it. Marking a transfer marks both sides reviewed, since saying what a pair is leaves nothing else to decide, and a new mark_transfer tool plus transfer_id on the transaction listing gives an agent a way to do it. Transfers were already out of every spent total; the missing coverage on spent-by-month is added. On the phone: no swipe actions, the bulk bar cut to Review / Spend from / More, grouped budgets, no edit on Spendable or credit cards, BALANCE on card debt, Apple's mark on Wallet accounts, and sign out lands on the sign-in screen. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The budget picker read the budget list instead of watching it, so on a screen that never loaded it the sheet opened with no rows - and a sheet sized to its contents with nothing in it is a sheet that never appears. That was both the picker sticking at the bottom and Spend from doing nothing. It watches now, and a test opens it from the bulk bar where nothing else loads the list. Spendable was the label over the figure and a row underneath it, the same word twice about two different numbers. The row goes on the current month and stays on a past one, where there is no figure above the list to read instead. Apple's mark comes from the system font at U+F8FF rather than a shape library's drawing of it. The compact title stays left where the large one was instead of travelling to the middle, a transaction's amount drops its red and green and a size, the line under a budget's figure sits under the figure, and the count in the bulk bar loses the rule to its right. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The line reading what was spent of what was budgeted belongs under the name it is about. It is LEFT, TO GO and BALANCE that move under the amount. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Dropping spendFrom changed the provider hash, and the .g.dart was left behind. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP budget type enum matched atoms while the value arrives from JSON as a string, so every create or update naming a type was refused as Invalid params. An end-to-end server test now goes through the transport that validates it.
Marking a transfer marks both sides reviewed, since saying what a pair is leaves nothing else to decide, and a new mark_transfer tool plus transfer_id on the transaction listing gives an agent a way to do it. Transfers were already out of every spent total; the missing coverage on spent-by-month is added.
On the phone: no swipe actions, the bulk bar cut to Review / Spend from / More, grouped budgets, no edit on Spendable or credit cards, BALANCE on card debt, Apple's mark on Wallet accounts, and sign out lands on the sign-in screen.