Skip to content

fix: add missing push parameters to hxLocation#96

Closed
sanchawebo wants to merge 2 commits into
michalsn:v2from
sanchawebo:develop
Closed

fix: add missing push parameters to hxLocation#96
sanchawebo wants to merge 2 commits into
michalsn:v2from
sanchawebo:develop

Conversation

@sanchawebo

Copy link
Copy Markdown

Description
I came across an issue with your amazing library and created a small fix.
As per hx-location documentation htmx consumes the push parameter but your API doesnt expose it.

Just a small addition. Tell me if this would need a test.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn
michalsn changed the base branch from develop to v2 July 20, 2026 15:45
@michalsn

Copy link
Copy Markdown
Owner

Thanks! It would be nice to have a test for this. Also, please let me know if you're planning any other additions, because if not, I will release a new version after merging this.

@sanchawebo

Copy link
Copy Markdown
Author

Thanks! It would be nice to have a test for this. Also, please let me know if you're planning any other additions, because if not, I will release a new version after merging this.

Will do. Furthermore i would add all extra params from HX-Location.
Also i'll add all new params at the end of the methods parameter list to not break existing code. Is this okay?

@michalsn michalsn changed the title Add push parameter to hxLocation fix: add missing push parameters to hxLocation Jul 21, 2026
@michalsn

Copy link
Copy Markdown
Owner

Sorry, but I cannot merge this now because your branch has some unrelated commits. You have to cherry-pick commits that contain only your changes.

@sanchawebo
sanchawebo marked this pull request as draft July 21, 2026 11:34
@sanchawebo sanchawebo closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants