Fix plugin autoclose unused import

[usfbih8u]

No description provided.

[JoeKar]

You can drop 028ff6f, because for builtin plugins we agreed to stay at v1.0.0.
The version isn't printed anyway:

micro/internal/config/plugin_installer.go

Lines 712 to 716 in 1c8b82b

	} else if p.Pack().Builtin {
	fmt.Fprintf(out, "%s (built-in)\n", p.Pack().Name)
	} else {
	fmt.Fprintf(out, "%s (%s)\n", p.Pack().Name, p.Version)
	}

[usfbih8u]

You can drop 028ff6f, because for builtin plugins we agreed to stay at v1.0.0.

I think this comes from this text:

"Right now the version number of internal plugins is somehow useless, since we never update them and so they become superfluous."^[https://github.com//pull/3810#issuecomment-3097640920] ~ Jöran Karl 3951388+JoeKar@users.noreply.github.com

A comment like this:

VERSION = "1.0.0" -- all built-in plugins fixed to 1.0.0

in all the plugins would be useful to reflect that policy in the code; in the future, we can change it.

I could make a PR with the changes, but I’d like you to give me the reasoning to include in the commit body so the commit history reflects why that decision was made.

Maybe the previous quote is enough. Your call.

[JoeKar]

I think this comes from this text:

Yes, more or less.
You can have a look in the history of the plugins and see that we have done changes, but never updated the version.

A comment like this:
[...]

Might be an option, or...

micro/internal/config/plugin_installer.go

Line 383 in 1c8b82b

version := GetInstalledPluginVersion(p.Name)

...is only called if !p.Builtin is true; otherwise, version is set to "0.0.0" or any other value. We can then remove VERSION entirely from the internal plugins and do not need a comment to justify the unmodified value.

The plugins.md#default-plugins must be updated to reflect that change, otherwise users will complain that they cannot load such examples, because they might not read until the end of the file stating:

To make updating the plugin work, the first line of your plugin's lua code should contain the version of the plugin. (Like this: VERSION = "1.0.0") Please make sure to use semver for versioning.

[usfbih8u]

I still think keeping VERSION is beneficial. Many people will look at the built-in plugins for examples of correctly structured plugins, and removing something as essential to the plugin manager as VERSION could mislead them.

It also makes the version explicit and readily visible to contributors. As you mentioned, placing it as the last line of the documentation file does not help either.

By the way, regarding “the first line of your plugin’s Lua code should contain the plugin’s version”: the line number does not matter, but this is a useful convention. The version declaration must not use local.

$ micro -plugin list | grep mdh
mdhelp (0.0.1)

after adding local to VERSION:

$ micro -plugin list | grep mdh
mdhelp (0.0.0-unknown)

I will create a separate PR to add the comments and correct the documentation, as these changes do not belong in this one. Feel free to close it if you remain unconvinced.