Skip to content

Location: Fix speed calculation for sub-second updates #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaVinci9196 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Location: Fix speed calculation for sub-second updates #3737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions ...ices-location/core/src/main/kotlin/org/microg/gms/location/manager/LastLocationCapsule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,21 @@ class LastLocationCapsule(private val context: Context) {
fun updateCoarseLocation(location: Location) {
location.elapsedRealtimeNanos = min(location.elapsedRealtimeNanos, SystemClock.elapsedRealtimeNanos())
location.time = min(location.time, System.currentTimeMillis())
if (lastCoarseLocation != null && lastCoarseLocation!!.elapsedMillis + EXTENSION_CLIFF > location.elapsedMillis) {
if (!location.hasSpeed()) {
location.speed = lastCoarseLocation!!.distanceTo(location) / ((location.elapsedMillis - lastCoarseLocation!!.elapsedMillis) / 1000)
LocationCompat.setSpeedAccuracyMetersPerSecond(location, location.speed)
}
if (!location.hasBearing() && location.speed > 0.5f) {
location.bearing = lastCoarseLocation!!.bearingTo(location)
LocationCompat.setBearingAccuracyDegrees(location, 180.0f)
val previousLocation = lastCoarseLocation
if (previousLocation != null) {
val elapsedMillis = location.elapsedMillis - previousLocation.elapsedMillis
if (elapsedMillis in 1..<EXTENSION_CLIFF) {
if (!location.hasSpeed()) {
val speed = previousLocation.distanceTo(location) * 1000f / elapsedMillis
if (speed.isFinite()) {
location.speed = speed
LocationCompat.setSpeedAccuracyMetersPerSecond(location, speed)
}
}
if (!location.hasBearing() && location.speed > 0.5f) {
location.bearing = previousLocation.bearingTo(location)
LocationCompat.setBearingAccuracyDegrees(location, 180.0f)
}
Comment on lines +73 to +83

@ale5000-git ale5000-git Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mar-v-in
I'm not sure but: what happens if the speed wasn't finite so it remain unset and then it check location.speed > 0.5f?
Maybe it need another location.hasSpeed() check?

}
}
lastCoarseLocation = newest(lastCoarseLocation, location)
Expand Down Expand Up @@ -159,4 +166,4 @@ class LastLocationCapsule(private val context: Context) {
}
}
}
}
}