RCS: Constellation/Asterism plus DroidGuard fixes and IID/key-ack follow-up (#2994) - #3749
Open
ylcharan wants to merge 55 commits into
Open
RCS: Constellation/Asterism plus DroidGuard fixes and IID/key-ack follow-up (#2994)#3749ylcharan wants to merge 55 commits into
ylcharan wants to merge 55 commits into
Conversation
Align DG cache naming and VM keys with stock GMS, preserve partial init replies, and fall back to phone number hints during Constellation provisioning.
Introduce shared phone-number and VM cache utilities, wire them into Constellation and DroidGuard, and add offline JUnit coverage for provisioning and tachyon-related logic.
Do not send GPNV with a blank IID token, reset is_public_key_acked when EC keys are replaced, keep only verified Messages/IMS Phenotype flags, and add Asterism consent request/response tests. Co-authored-by: Cursor <cursoragent@cursor.com>
DummyService returns API_DISABLED and aborts Messages RCS setup. Accept the bind for Google packages, log unknown binder codes, and keep a manifest regression test so the action cannot fall back onto DummyService. Co-authored-by: Cursor <cursoragent@cursor.com>
This reverts commit eca1f20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthManager.getIidToken()from returning""after failure (that could send empty GPNV requests) and clearsis_public_key_ackedwhenever missing/corrupt EC keys are regenerated.apps.messaging#…map key). Does not add attestation-disable flags. Does not add an emptyrcs.STARTbinder as a svc 189 fix.Test plan
./gradlew :play-services-constellation-core:testDebugUnitTest./gradlew :play-services-asterism-core:testDebugUnitTest(Get/Set Asterism consent request/response parcel + mapping)./gradlew :play-services-droidguard:testDebugUnitTest./gradlew :play-services-constellation-core:lintDebug :play-services-asterism-core:lintDebug :play-services-droidguard:lintDebug :play-services-core:lintVtmDefaultDebug(0 errors; no NewApi/RestrictedApi in these modules)PERMISSION_DENIEDThis PR does not claim the locked-bootloader E2E finish line. Stock GMS daily drivers cannot take this APK; a microG ROM (and separately a signed CalyxOS Pixel) is still required for that evidence.
Related
play-services-constellation#3359, Implementplay-services-asterism#3360 (@opstic)Made with Cursor