Skip to content

Fix screen-lock exclude credential check (#3751) #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamcparsons wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix screen-lock exclude credential check (#3751) #3752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...c/main/kotlin/org/microg/gms/fido/core/transport/screenlock/ScreenLockTransportHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ class ScreenLockTransportHandler(private val activity: FragmentActivity, callbac
): AuthenticatorResponseWithUser<AuthenticatorAttestationResponse> {
if (options.type != RequestOptionsType.REGISTER) throw RequestHandlingException(ErrorCode.INVALID_STATE_ERR)
val knownRegistrationInfo = database.getKnownRegistrationInfo(options.rpId)
Comment thread
adamcparsons marked this conversation as resolved.
.filter { it.transport == Transport.SCREEN_LOCK }
for (descriptor in options.registerOptions.excludeList.orEmpty()) {
val credentialBase64 = descriptor.id.toBase64(Base64.NO_WRAP or Base64.NO_PADDING or Base64.URL_SAFE)
val excluded = knownRegistrationInfo.any { it.credential == credentialBase64 }
Expand Down