NO SAF-T: skip currency export when currency matches LCY code#29959
Open
jeffreybulanadi wants to merge 2 commits intomicrosoft:mainfrom
Open
NO SAF-T: skip currency export when currency matches LCY code#29959jeffreybulanadi wants to merge 2 commits intomicrosoft:mainfrom
jeffreybulanadi wants to merge 2 commits intomicrosoft:mainfrom
Conversation
In GetFCYData, when a Customer, Vendor, or Bank Account Ledger Entry has a Currency Code that equals the company LCY code, the export was incorrectly including CurrencyCode, CurrencyAmount, and ExchangeRate XML nodes in the SAF-T output. Add GeneralLedgerSetup.Get() once after the Export Currency Information guard, then bail out early in each ledger-entry branch when the retrieved currency code matches the LCY code. The early exit is placed before CalcFields to avoid an unnecessary database round-trip. Applied identically to both SAF-T v1.0 (codeunit 10673) and SAF-T v1.3 (codeunit 10692). Fixes microsoft#26554
JesperSchulz
added
Finance
Contributor
|
@jeffreybulanadi, could you add some tests? Then I'll process 😊 |
…cy block Add automated tests to verify that ledger entries with a currency code equal to the company LCY code do not export currency information (CurrencyCode, CurrencyAmount, ExchangeRate) in the SAF-T XML output when the Export Currency Information option is enabled. Tests cover vendor, customer, and bank account ledger entries for both SAF-T version 1.0 (SAFTXMLTests.Codeunit.al) and version 1.3 (SAFTXMLTests13.Codeunit.al).
Author
|
Hi @JesperSchulz, added automated tests for the LCY currency code fix. Six new test methods added across both SAF-T versions: SAFTXMLTests.Codeunit.al (v1.0):
SAFTXMLTests13.Codeunit.al (v1.3):
Each test mocks a GL entry and the corresponding ledger entry with Currency Code set to the company LCY code (read from GeneralLedgerSetup after SetupSAFT sets it), runs the export with Export Currency Information enabled, and verifies the DebitAmount node contains only n1:Amount with no CurrencyCode, CurrencyAmount, or ExchangeRate child elements. |
jeffreybulanadi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When exporting SAF-T (both v1.0 and v1.3), if a Bank Account Ledger Entry (or Customer/Vendor Ledger Entry) has a Currency Code that equals the company LCY code, the export was incorrectly writing CurrencyCode, CurrencyAmount, and ExchangeRate XML nodes for what is effectively a domestic currency entry.
The root cause is in GetFCYData: after checking for a blank Currency Code, the function did not check whether the currency equals the LCY code. A bank account explicitly configured with LCY code (e.g. NOK on a Norwegian company) would pass the blank-check and inject spurious currency XML on all G/L entries in the same transaction.
Changes
Related Issue
Fixes #26554
Fixes AB#632882