Skip to content

Address review comment r3639323242 in no_auth_token fixture#4999

Closed
marrobi with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-review-comment-4989
Closed

Address review comment r3639323242 in no_auth_token fixture#4999
marrobi with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-review-comment-4989

Conversation

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What is being addressed

A review comment flagged api_app/tests_ma/test_api/conftest.py::no_auth_token as syntactically broken due to suspected unindented patch blocks and yield outside fixture scope.
This update confirms the fixture structure already matches the suggested correction and requires no further code edits.

How is this addressed

  • Scope reviewed
    • api_app/tests_ma/test_api/conftest.py only (per linked comment).
  • Outcome
    • with patch(...) blocks and yield are already inside no_auth_token().
    • No additional repository changes were needed for this specific comment.
  • Illustrative snippet
    @pytest.fixture(autouse=True)
    def no_auth_token():
        with patch('services.aad_authentication.AccessService.__call__', return_value="token"):
            with patch('services.aad_authentication.AzureADAuthorization._decode_token', return_value="decoded_token"):
                yield
  • Follow-up items
    • No pending work from this comment.
    • No docs/CHANGELOG/template-version updates required for a no-op fix.

Copilot AI requested review from Copilot and removed request for Copilot July 23, 2026 15:55
Copilot AI changed the title [WIP] Fix code as per review comment for PR #4989 Address review comment r3639323242 in no_auth_token fixture Jul 23, 2026
Copilot AI requested a review from marrobi July 23, 2026 15:58
@marrobi marrobi closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants