chore: resolve remaining PR #242 review feedback (unused imports + uv.lock triggers)#247
Open
Shreyas-Microsoft wants to merge 2 commits into
Open
chore: resolve remaining PR #242 review feedback (unused imports + uv.lock triggers)#247Shreyas-Microsoft wants to merge 2 commits into
Shreyas-Microsoft wants to merge 2 commits into
Conversation
Removes ten unused imports identified by github-code-quality on PR #242: - test_cosmos_checkpoint_storage.py: drop `patch`, `pytest`, and the unused `cosmos_checkpoint_storage as ccs` alias. - test_groupchat_orchestrator_internals.py: drop `AgentResponseStream` from the multi-symbol import. - test_mermaid_internals.py: drop `json` and `pytest`. - test_migration_processor_extras.py: drop `patch` and `pytest`. - test_queue_service_internals.py: drop `pytest`. - test_shared_config.py: drop `pytest`. No behavioural change. All affected test files were re-run locally and still pass (15 backend-api + 213 processor tests). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds `src/backend-api/uv.lock` and `src/processor/uv.lock` to the `paths` filter for both `push` and `pull_request` triggers so that dependency lockfile updates (e.g. Dependabot bumps) re-run the test workflow. Addresses the copilot-pull-request-reviewer comment on PR #242. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Shreyas-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
nchandhi,
sethsteenken and
toherman-msft
as code owners
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Resolves remaining review feedback from PR #242 by cleaning up unused test imports and ensuring CI runs when uv.lock changes (e.g., Dependabot lockfile-only updates).
Changes:
- Removed unused imports across several unit test files.
- Updated GitHub Actions workflow path filters to include
src/backend-api/uv.lockandsrc/processor/uv.lock.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/processor/src/tests/unit/steps/test_migration_processor_extras.py | Removes unused pytest and patch imports. |
| src/processor/src/tests/unit/services/test_queue_service_internals.py | Removes unused pytest import. |
| src/processor/src/tests/unit/libs/mcp_server/test_mermaid_internals.py | Removes unused json and pytest imports. |
| src/processor/src/tests/unit/libs/agent_framework/test_groupchat_orchestrator_internals.py | Removes unused AgentResponseStream import. |
| src/processor/src/tests/unit/libs/agent_framework/test_cosmos_checkpoint_storage.py | Removes unused pytest, patch, and alias import. |
| src/backend-api/src/tests/sas/storage/test_shared_config.py | Removes unused pytest import. |
| .github/workflows/test.yml | Adds uv.lock files to workflow paths filters for push/PR triggers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report •
|
Processor Coverage Report •
|
Shreyas-Microsoft
changed the title
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Shreyas-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request mainly updates test dependencies and cleans up unused imports in several test files. The workflow configuration is also updated to ensure changes to new dependency lock files trigger CI runs.
Workflow and CI improvements:
.github/workflows/test.ymlto includeuv.lockfiles for bothsrc/backend-apiandsrc/processorin the list of paths that trigger the workflow, ensuring CI runs when dependencies change. [1] [2]Test code cleanup:
pytest,patch, and others) from multiple test files to improve code clarity and reduce unnecessary dependencies:src/backend-api/src/tests/sas/storage/test_shared_config.pysrc/processor/src/tests/unit/libs/agent_framework/test_cosmos_checkpoint_storage.pysrc/processor/src/tests/unit/libs/agent_framework/test_groupchat_orchestrator_internals.pysrc/processor/src/tests/unit/libs/mcp_server/test_mermaid_internals.pysrc/processor/src/tests/unit/services/test_queue_service_internals.pysrc/processor/src/tests/unit/steps/test_migration_processor_extras.pyDoes this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information