Adding Offload Test into DXC build pipeline#8584
Conversation
joaosaffran
force-pushed
the
vk-release/build-test-pipeline
branch
6 times, most recently
from
2959f34 to
6c3d8b4
Compare
joaosaffran
force-pushed
the
vk-release/build-test-pipeline
branch
from
6c3d8b4 to
fad2cb9
Compare
joaosaffran
changed the title
| variables: | ||
| LAVAPIPE_VERSION: '26.1.2' | ||
| WARP_VERSION: '1.0.19' | ||
| VS_DEV: 'C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat' |
There was a problem hiding this comment.
We shouldn't hardcode this string. We should be able to reuse some of the logic in the other scripts to find this.
| - task: BatchScript@1 | ||
| displayName: 'Set up MSVC environment' | ||
| inputs: | ||
| filename: '$(VS_DEV)' |
There was a problem hiding this comment.
Does hctstart.cmd actually do this for you? Might be a way to avoid hard coding the script path?
| displayName: 'DXIL Compat Suite Tests (1.8 point release)' | ||
| condition: succeededOrFailed() | ||
|
|
||
| - script: | |
There was a problem hiding this comment.
For PR builds, I'm wondering if we should only do this if the PR has a particular label on it? I don't think we'll want to gate all PRs on this since it'll add significant time to the builds.
| $dst = "$(Build.ArtifactStagingDirectory)\dxc" | ||
| New-Item -ItemType Directory -Force -Path $dst | Out-Null | ||
| foreach ($f in @("dxc.exe","dxv.exe","dxcompiler.dll","dxil.dll")) { | ||
| if (Test-Path "$bin\$f") { Copy-Item "$bin\$f" $dst } else { Write-Warning "missing $f" } |
There was a problem hiding this comment.
Instead of logging a warning, should we fail if one of the files doesn't exist?
| condition: succeededOrFailed() | ||
| variables: | ||
| LAVAPIPE_VERSION: '26.1.2' | ||
| WARP_VERSION: '1.0.19' |
There was a problem hiding this comment.
Are hard coded versions intentional? I worry about needing to consistently bump these versions.
4 participants
This patch adds a new stage into DXC build pipeline, it runs the offload-test agains the built binaries, it uses WARP for DXIL and lava-pipe for SPIRV builds.
Part of: microsoft/hlsl-specs#886