fix: address SFI security compliance issues#435
Open
Prachig-Microsoft wants to merge 2 commits into
Open
Conversation
- Enable infrastructure encryption (double encryption) for storage account - Add Security solution to Log Analytics workspace for SecurityEvent table - Add Windows Security Audit Event Logs (EventID 4624/4625) to data collection rules - Route Microsoft-SecurityEvent stream to Log Analytics in both main.bicep and main_custom.bicep Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Prachig-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
marktayl1,
nchandhi and
toherman-msft
as code owners
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses SFI security compliance by enabling infrastructure (double) encryption on the storage account and onboarding the Security solution + Windows Security Audit events (EventIDs 4624/4625) to Log Analytics via the data collection rule, in both the standard and custom infra templates.
Changes:
- Enable
requireInfrastructureEncryption: trueon the storage account module. - Deploy a
Microsoft.OperationsManagement/solutions"Security" solution to the LA workspace when private networking + monitoring are enabled, and gate the DCR module on it. - Add a
Microsoft-SecurityEventwindows event log data source and matching LA dataflow to the DCR (and fix the stream fromMicrosoft-WindowsEventtoMicrosoft-SecurityEventinmain_custom.bicep).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/modules/storageAccount.bicep | Turns on infrastructure (double) encryption. |
| infra/main.bicep | Adds Security solution resource + Windows Security Event data source/dataflow in DCR. |
| infra/main_custom.bicep | Same Security solution + DCR additions; corrects stream name to Microsoft-SecurityEvent. |
| infra/main.json | Regenerated ARM JSON reflecting the above (template hashes, security solution, DCR updates, double encryption). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
had a problem deploying
to
production
GitHub Actions
Failure
4 tasks
Revert the Microsoft.OperationsManagement/solutions 'Security' resource and the Microsoft-SecurityEvent data source/dataflow added in the previous commit. The SecurityEvent table is not provisioned by OMSGallery/Security in modern subscriptions and this workload has no Windows VMs to source the events, which was causing 'InvalidOutputTable' deployment failures. Retain only the storage account double-encryption change.
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information