Skip to content

fix: Dev v4 to main merge#970

Merged
Prajwal-Microsoft merged 23 commits into
mainfrom
dev-v4
May 12, 2026
Merged

fix: Dev v4 to main merge#970
Prajwal-Microsoft merged 23 commits into
mainfrom
dev-v4

Conversation

@Dhruvkumar-Microsoft
Copy link
Copy Markdown
Collaborator

Purpose

This pull request makes several documentation and configuration improvements to ensure consistency and clarity when deploying the solution accelerator. The most important changes include correcting environment parameter names and defaults, updating Azure region recommendations, and clarifying instructions in the documentation.

Parameter and Configuration Updates:

  • Renamed the Docker image tag environment variable from AZURE_ENV_IMAGETAG to AZURE_ENV_IMAGE_TAG, updated its default value from latest_v3 to latest_v4, and ensured consistent usage in both documentation and infrastructure configuration (docs/CustomizingAzdParameters.md, infra/main.parameters.json). [1] [2]

Documentation Improvements:

  • Updated the recommended Azure regions in the README.md to reflect currently available regions for required services.
  • Clarified the allowed length for environment names from 3-20 to 3-16 characters in the customization instructions (docs/CustomizingAzdParameters.md).

Minor Corrections:

  • Fixed a typo in the Azure App Service authentication setup guide ("idenity" to "identity") (docs/azure_app_service_auth_setup.md).
  • Updated a UI instruction from "Add a platform" to "Add redirect URI" in the app registration guide for accuracy (docs/create_new_app_registration.md).

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns deployment documentation and azd parameterization for the v4 branch by updating region guidance, correcting/standardizing environment parameter naming, and fixing minor documentation inaccuracies.

Changes:

  • Update README recommended Azure regions for required services.
  • Set a default container image tag (latest_v4) via AZURE_ENV_IMAGE_TAG in infra/main.parameters.json and document the parameter consistently.
  • Minor doc corrections (environment name length guidance, UI instruction wording, typo fix).

Reviewed changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Updates example Azure regions to reflect current availability guidance.
infra/main.parameters.json Uses AZURE_ENV_IMAGE_TAG with a latest_v4 default for backend/frontend/MCP image tags.
docs/CustomizingAzdParameters.md Updates env name length guidance and standardizes the image tag env var name/default.
docs/create_new_app_registration.md Adjusts an Azure Portal UI instruction related to redirect URI configuration.
docs/azure_app_service_auth_setup.md Fixes a typo (“idenity” → “identity”) in the auth setup steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/create_new_app_registration.md Outdated
chore: Bicep Parameter validation email format change
feat: implementation of logout functionality
Copilot AI review requested due to automatic review settings May 8, 2026 06:46
Comment thread src/App/src/components/auth/LoginButton.tsx Fixed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 17 changed files in this pull request and generated 6 comments.

Comment thread src/App/src/components/auth/LoginButton.tsx Outdated
Comment thread src/App/src/components/auth/LoginButton.tsx
Comment thread src/App/src/App.tsx
Comment thread infra/scripts/validate_bicep_params.py Outdated
Comment thread .github/workflows/validate-bicep-params.yml
Comment thread src/App/src/App.tsx
…ng logic

- Update email body handling in Bicep validation workflow to include fallback messages when HTML reports are not generated.
- Refactor `fetchCurrentUser` to `hydrateCurrentUser` in app slice, improving user state management.
- Remove unused `fetchCurrentUser` async thunk and related error handling.
- Adjust LoginButton component to streamline authentication logic.
- Minor documentation update for clarity in app registration instructions.
fix: copilot comments resolve code changes
@Roopan-Microsoft Roopan-Microsoft self-requested a review May 12, 2026 12:03
@Prajwal-Microsoft Prajwal-Microsoft merged commit bcec9db into main May 12, 2026
11 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants