chore: Add tags to prevent SFI W18 Policy violation#971
Open
NirajC-Microsoft wants to merge 4 commits into
Open
chore: Add tags to prevent SFI W18 Policy violation#971NirajC-Microsoft wants to merge 4 commits into
NirajC-Microsoft wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request focuses on improving tag management for deployed resources and making minor template optimizations in the infrastructure code. The main enhancement is the merging of resource group tags with custom tags for the container app environment, ensuring better consistency and traceability. Additionally, there are small updates to resource scoping and dependency ordering, as well as changes to the Bicep-to-ARM template generator metadata.
Tag management improvements:
containerAppEnvironmentmodule in bothinfra/main.bicepandinfra/main_custom.bicepto mergeresourceGroup().tagswith customtags, ensuring that all resources inherit tags from the resource group in addition to any custom tags. [1] [2]infra/main.json) to useshallowMerge(createArray(resourceGroup().tags, parameters('tags'))), aligning the JSON output with the new tag merging logic.Template and resource definition updates:
scopeproperty for some resources (e.g.,Microsoft.CognitiveServices/accountsandMicrosoft.Web/sites) to useformat()instead ofresourceId()for improved clarity and consistency. [1] [2]dependsOnarray for private DNS zones to ensure correct deployment sequencing.Bicep/ARM template metadata:
infra/main.jsonto reflect the changes and maintain consistency. [1] [2] [3] [4] [5] [6] [7]Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information