feat: Enhance email template, add RG owner tag, scalability input#992
Open
Vamshi-Microsoft wants to merge 2 commits into
Open
feat: Enhance email template, add RG owner tag, scalability input#992Vamshi-Microsoft wants to merge 2 commits into
Vamshi-Microsoft wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the GitHub Actions deployment workflows: it tags resource groups with the triggering GitHub actor as Owner, adds an opt-in enable_scalability input that flips the enableScalability Bicep parameter on WAF deployments, clarifies several input descriptions, and replaces the plain-text Logic App email bodies with a richer HTML template (with light HTML escaping of user-controlled fields).
Changes:
- Add Owner tagging on resource group create/update across
deploy.yml,deploy-waf.yml, andjob-deploy.yml. - Introduce
enable_scalability/ENABLE_SCALABILITYinput plumbed throughdeploy-v2.yml,deploy-orchestrator.yml,job-deploy.yml, and applied viajqinjob-deploy-linux.yml/job-deploy-windows.yml. - Rework
job-send-notification.ymlto send a styled HTML email template with status "pills" and a shared (per-step)html_escapehelper, plus tidied input labels in workflow descriptions.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/deploy.yml | Adds Owner tag on RG create and merges Owner tag on existing RG. |
| .github/workflows/deploy-waf.yml | Adds Owner tag on RG create/update with improved logging. |
| .github/workflows/deploy-v2.yml | Adds enable_scalability input, validation, and output wiring; updates input labels. |
| .github/workflows/deploy-orchestrator.yml | Forwards enable_scalability and updates input descriptions. |
| .github/workflows/job-deploy.yml | Adds enable_scalability input, Owner tag on RG, forwards new flag to Linux/Windows jobs. |
| .github/workflows/job-deploy-linux.yml | Validates ENABLE_SCALABILITY and patches infra/main.parameters.json via jq when WAF is enabled. |
| .github/workflows/job-deploy-windows.yml | Same WAF-only jq patching for enableScalability as the Linux job. |
| .github/workflows/job-send-notification.yml | Replaces text email bodies with HTML templates, adds status pills and partial HTML escaping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several improvements and new features to the GitHub Actions workflows for Azure deployment, with a focus on enhanced resource group tagging, support for scalability options in WAF deployments, and clearer input descriptions across workflows. The changes ensure better traceability of deployments, allow opt-in scalability features for WAF, and improve the overall clarity and consistency of workflow parameters.
Resource Group Tagging and Management:
WAF Scalability Feature:
enable_scalability/ENABLE_SCALABILITY) to allow opt-in enabling of scalability features specifically for WAF deployments. This is validated and passed through the workflows, and the ARM template parameter is set accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Input and Parameter Description Improvements:
azure_location,waf_enabled,EXP,build_docker_image,cleanup_resources, resource IDs, and web app URLs) to make their purpose and usage clearer and more consistent across workflows. [1] [2] [3] [4] [5] [6] [7] [8] [9]Validation Enhancements:
Workflow Consistency:
Let me know if you want to walk through any specific workflow or change in more detail!
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information