Add review context mapping protocols#263
Open
Alan-Jowett wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands PromptKit’s reusable protocol library by adding two new optional protocols aimed at improving review quality: one for Rust clone scrutiny and one for mapping repo standards and design docs before a review. The components are added without modifying any existing templates, and manifest.yaml is updated so the bootstrap engine can discover them.
Changes:
- Added a new reasoning protocol to inventory repo standards and map changed areas to relevant design documents (
design-context-mapping). - Added a new Rust-focused analysis protocol to evaluate
.clone()usage and encourage borrow-first alternatives where appropriate (clone-discipline-rust). - Registered both protocols in
manifest.yamlunder the appropriate protocol sections.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| protocols/reasoning/design-context-mapping.md | New reasoning protocol for repo-standards discovery and change-to-design-doc mapping before reviews. |
| protocols/analysis/clone-discipline-rust.md | New Rust analysis protocol for identifying unnecessary/high-cost cloning and suggesting safer alternatives. |
| manifest.yaml | Adds both new protocols so they’re discoverable by the PromptKit bootstrap/manifest system. |
Add clone-discipline-rust and design-context-mapping based on public Sashiko review guidance. These protocols capture reusable Rust clone review checks and repo-local standards and design mapping for review workflows. Suggested-by: derekbarbosa <derekasobrab@gmail.com> Suggested-by: Sven Van Asbroeck <TheSven73@googlemail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
198d7b2 to
e857803
Compare
Clarify that clone-discipline-rust should treat deterministic lint output as baseline evidence without stopping semantic review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
| clear ownership boundary from clones that merely silence the borrow | ||
| checker or duplicate expensive data without need. | ||
|
|
||
| ## Deterministic Baseline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two reusable PromptKit protocols derived from analysis of the
public Sashiko review guidance. The new components capture Rust clone
review discipline and repo-local standards and design-doc mapping for
review workflows without changing existing templates.
New Components
Design Decisions
applicable_to: []ratherthan modifying existing templates in this PR.
the Sashiko material: clone review discipline and design-context
discovery.
introducing a new review template or persona.
copying source prompt text verbatim.
Improvement Log
review-pull-requestwith an optionalrepo standards and design-doc gathering step.
review-pull-requestwhen matching design docs exist.review-codeandreview-pull-requestfor author-facing reviews.mode that emits unified diffs for actionable findings.
Acknowledgment
This PR was informed by public Sashiko materials:
skills/review-pr/SKILL.md, introduced byderekbarbosaand laterupdated by Sven Van Asbroeck (
@TheSven73)GEMINI.mdskills/review-pr/references/clone-discipline.mddesigns/*review design documentsThe source repository is licensed under Apache-2.0. Author notification
is still pending.
Checklist