Skip to content

Add review context mapping protocols#263

Open
Alan-Jowett wants to merge 2 commits into
mainfrom
assimilate-sashiko-review-pr
Open

Add review context mapping protocols#263
Alan-Jowett wants to merge 2 commits into
mainfrom
assimilate-sashiko-review-pr

Conversation

@Alan-Jowett

Copy link
Copy Markdown
Member

Summary

Adds two reusable PromptKit protocols derived from analysis of the
public Sashiko review guidance. The new components capture Rust clone
review discipline and repo-local standards and design-doc mapping for
review workflows without changing existing templates.

New Components

Type Name Path Description
protocol (analysis) clone-discipline-rust protocols/analysis/clone-discipline-rust.md Rust review protocol for challenging unnecessary or high-cost cloning.
protocol (reasoning) design-context-mapping protocols/reasoning/design-context-mapping.md Pre-review protocol for discovering repo standards and mapping changed modules to relevant design docs.

Design Decisions

  • Added standalone optional protocols with applicable_to: [] rather
    than modifying existing templates in this PR.
  • Kept the contribution focused on the strongest reusable deltas from
    the Sashiko material: clone review discipline and design-context
    discovery.
  • Reused existing review personas, formats, and templates rather than
    introducing a new review template or persona.
  • Synthesized the protocol wording for PromptKit conventions instead of
    copying source prompt text verbatim.

Improvement Log

  • Follow-up candidate: extend review-pull-request with an optional
    repo standards and design-doc gathering step.
  • Follow-up candidate: add explicit design-alignment review language to
    review-pull-request when matching design docs exist.
  • Follow-up candidate: add terse, fix-oriented finding guidance to
    review-code and review-pull-request for author-facing reviews.
  • Follow-up candidate: explore a review-to-patch workflow or output
    mode that emits unified diffs for actionable findings.

Acknowledgment

This PR was informed by public Sashiko materials:

  • skills/review-pr/SKILL.md, introduced by derekbarbosa and later
    updated by Sven Van Asbroeck (@TheSven73)
  • GEMINI.md
  • skills/review-pr/references/clone-discipline.md
  • designs/* review design documents

The source repository is licensed under Apache-2.0. Author notification
is still pending.

Checklist

  • All files have SPDX license headers
  • YAML frontmatter is valid and complete
  • Component names match file names (kebab-case)
  • manifest.yaml updated with all new components
  • No vague instructions in protocols or templates
  • Protocols have numbered, ordered phases
  • Templates have a quality checklist section
  • New components do not conflict with existing ones

Copilot AI review requested due to automatic review settings July 8, 2026 21:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands PromptKit’s reusable protocol library by adding two new optional protocols aimed at improving review quality: one for Rust clone scrutiny and one for mapping repo standards and design docs before a review. The components are added without modifying any existing templates, and manifest.yaml is updated so the bootstrap engine can discover them.

Changes:

  • Added a new reasoning protocol to inventory repo standards and map changed areas to relevant design documents (design-context-mapping).
  • Added a new Rust-focused analysis protocol to evaluate .clone() usage and encourage borrow-first alternatives where appropriate (clone-discipline-rust).
  • Registered both protocols in manifest.yaml under the appropriate protocol sections.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
protocols/reasoning/design-context-mapping.md New reasoning protocol for repo-standards discovery and change-to-design-doc mapping before reviews.
protocols/analysis/clone-discipline-rust.md New Rust analysis protocol for identifying unnecessary/high-cost cloning and suggesting safer alternatives.
manifest.yaml Adds both new protocols so they’re discoverable by the PromptKit bootstrap/manifest system.

Add clone-discipline-rust and design-context-mapping based on
public Sashiko review guidance.

These protocols capture reusable Rust clone review checks and
repo-local standards and design mapping for review workflows.

Suggested-by: derekbarbosa <derekasobrab@gmail.com>
Suggested-by: Sven Van Asbroeck <TheSven73@googlemail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
@Alan-Jowett Alan-Jowett force-pushed the assimilate-sashiko-review-pr branch from 198d7b2 to e857803 Compare July 8, 2026 22:09
Clarify that clone-discipline-rust should treat deterministic
lint output as baseline evidence without stopping semantic review.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Copilot AI review requested due to automatic review settings July 8, 2026 22:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

clear ownership boundary from clones that merely silence the borrow
checker or duplicate expensive data without need.

## Deterministic Baseline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants