More type safe Infiniium driver - #8457
Open
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 3 commits into
Open
More type safe Infiniium driver#8457Jens Hedegaard Nielsen (jenshnielsen) wants to merge 3 commits into
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 3 commits into
Conversation
The driver narrowed root_instrument and instrument to the concrete driver classes with an annotation plus a suppression, and worked around pyvisa typing the return of read_binary_values and query_binary_values as Sequence[float] regardless of the requested container. Spell both as cast instead, which all three type checkers accept and which drops five suppressions.
Jens Hedegaard Nielsen (jenshnielsen)
requested a review
from a team
as a code owner
August 28, 2026 08:00
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8457 +/- ##
==========================================
+ Coverage 71.15% 71.76% +0.60%
==========================================
Files 305 305
Lines 31976 31983 +7
==========================================
+ Hits 22753 22952 +199
+ Misses 9223 9031 -192 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add a pyvisa-sim yaml for the Infiniium and a test module covering the type narrowing added to ``DSOTraceParam``: the ``root_instrument`` property, the ``setpoints`` property for channels and for FFT and non-FFT functions, and the ``update_fft_setpoints`` guard. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 320931ad-ca27-41fb-a20d-2c065c99700f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.