Preserve dream lineage across manifest parent fallbacks - #28
Xingdi (Eric) Yuan (xingdi-eric-yuan) merged 9 commits into
Conversation
Co-authored-by: xingdi-eric-yuan <4028684+xingdi-eric-yuan@users.noreply.github.com>
Co-authored-by: xingdi-eric-yuan <4028684+xingdi-eric-yuan@users.noreply.github.com>
Co-authored-by: xingdi-eric-yuan <4028684+xingdi-eric-yuan@users.noreply.github.com>
Co-authored-by: xingdi-eric-yuan <4028684+xingdi-eric-yuan@users.noreply.github.com>
Co-authored-by: xingdi-eric-yuan <4028684+xingdi-eric-yuan@users.noreply.github.com>
|
Copilot That said, the latest commit (63451f3) takes this PR into someone else's Both PRs add a file named This PR's port is also incomplete. It moved Windows from 209 failures to 24,
Suggestion: drop the Windows changes from this PR and keep it to the lineage |
Co-authored-by: xingdi-eric-yuan <4028684+xingdi-eric-yuan@users.noreply.github.com>
Co-authored-by: xingdi-eric-yuan <4028684+xingdi-eric-yuan@users.noreply.github.com>
Dropped the Windows CI changes in |
Xingdi (Eric) Yuan (xingdi-eric-yuan)
left a comment
There was a problem hiding this comment.
LGTM
Dream reconciliation crashed on null
parent_branchvalues and silently indexed children as roots when lineage used alternate metadata. The repair path inherited the same gaps.Parent resolution
Index repair
Regression coverage
update_indexrecords a genuine child dream as a root, and crashes onparent_branch: null#27