Skip to content

Update web ref dependencies - #2556

Merged
github-actions[bot] merged 3 commits into
microsoft:mainfrom
Bashamega:bump/webref-9-19
Oct 7, 2026
Merged

github-actions[bot] merged 3 commits into
microsoft:mainfrom
Bashamega:bump/webref-9-19

Conversation

@Bashamega

Copy link
Copy Markdown
Contributor

Update dependencies in package-lock.json:

  • Bump @webref/css to 8.7.5
  • Bump @webref/elements to 2.9.0
  • Bump @webref/events to 1.26.0

A separate upcoming PR will update @webref/idl, which is a larger change.

This PR only updates the dependency versions; there are no baseline changes.

…@webref/elements to 2.9.0, and @webref/events to 1.26.0.

Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

@Bashamega

Copy link
Copy Markdown
Contributor Author

Hello Kagami Sascha Rosylight (@saschanaz)
Would you mind checking this?

@saschanaz

Copy link
Copy Markdown
Contributor

No diff? Sure. LGTM

Comment thread package-lock.json Outdated
"@webref/events": "^1.18.6",
"@webref/css": "^8.7.5",
"@webref/elements": "^2.9.0",
"@webref/events": "^1.26.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are changing package.json and npm i, but doing so makes this change. Consider changing packago.json back and then run npm i again to change this back.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the tip updated

-
Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>
@saschanaz

Copy link
Copy Markdown
Contributor

LGTM?

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) I think #2553 broke it: https://github.com/microsoft/TypeScript-DOM-lib-generator/actions/runs/37586879487

Error: Could not create GitHub App installation token: 422 Unprocessable Entity: {"message":"The permissions requested are not granted to this installation.","documentation_url":"https://docs.github.com/rest/reference/apps#create-an-installation-access-token-for-an-app","status":"422"}

@jakebailey

Copy link
Copy Markdown
Member

Darn, okay

@jakebailey

Copy link
Copy Markdown
Member

You can try again, but I suspect it'll hit the same workflow error I was trying to solve.

If it doesn't work I'm happy to click merge 🙂‍↕️

@saschanaz

Copy link
Copy Markdown
Contributor

LGTM, but if it fails you also have the ability to rebase...

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

I wonder rebase can be done by CI, or merge from main

@Bashamega

Copy link
Copy Markdown
Contributor Author

Rebased for you Kagami Sascha Rosylight (@saschanaz) :)

@saschanaz

Copy link
Copy Markdown
Contributor

LGTM

@github-actions
github-actions Bot merged commit 5d15e95 into microsoft:main Oct 7, 2026
5 checks passed
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks!

@saschanaz
Kagami Sascha Rosylight (saschanaz) deleted the bump/webref-9-19 branch October 7, 2026 08:54
@saschanaz

Copy link
Copy Markdown
Contributor

Suspiciously the bot doesn't report the failure anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants