Repository navigation
Update web ref dependencies - #2556
Conversation
…@webref/elements to 2.9.0, and @webref/events to 1.26.0. Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>
|
Thanks for the PR! This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged. |
|
Hello Kagami Sascha Rosylight (@saschanaz) |
|
No diff? Sure. LGTM |
| "@webref/events": "^1.18.6", | ||
| "@webref/css": "^8.7.5", | ||
| "@webref/elements": "^2.9.0", | ||
| "@webref/events": "^1.26.0", |
There was a problem hiding this comment.
I think you are changing package.json and npm i, but doing so makes this change. Consider changing packago.json back and then run npm i again to change this back.
There was a problem hiding this comment.
Thank you for the tip updated
|
LGTM? |
|
Jake Bailey (@jakebailey) I think #2553 broke it: https://github.com/microsoft/TypeScript-DOM-lib-generator/actions/runs/37586879487
|
|
Darn, okay |
|
You can try again, but I suspect it'll hit the same workflow error I was trying to solve. If it doesn't work I'm happy to click merge 🙂 |
|
LGTM, but if it fails you also have the ability to rebase... |
|
I wonder rebase can be done by CI, or merge from main |
|
Rebased for you Kagami Sascha Rosylight (@saschanaz) :) |
|
LGTM |
|
Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks! |
|
Suspiciously the bot doesn't report the failure anymore? |
Update dependencies in
package-lock.json:@webref/cssto8.7.5@webref/elementsto2.9.0@webref/eventsto1.26.0A separate upcoming PR will update
@webref/idl, which is a larger change.This PR only updates the dependency versions; there are no baseline changes.