Update danger and danger plugins to latest versions - #3506
Conversation
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
…angerfile.ts Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Copilot also update the other danger plugins
There was a problem hiding this comment.
Updated danger-plugin-spellcheck from ^1.5.0 to ^2.1.0. danger-plugin-lighthouse was already at the latest (^0.5.2). Verified pnpm danger ci works correctly with the updated plugin. (d329652)
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Updates
dangerand its plugins to their latest versions per DefinitelyTyped/DefinitelyTyped@c1bf2c9.package.json: Bumpdangerfrom^9.2.10to^13.0.5, bumpdanger-plugin-spellcheckfrom^1.5.0to^2.1.0(danger-plugin-lighthousewas already at latest^0.5.2)dangerfile.ts: Changed from ESMimportto CJSrequire()with destructured default export to avoid CJS/ESM interop issues with danger 13's transpilerDanger 13's transpiler, when no root
tsconfig.jsonis present, does not override the module system to CommonJS. This causes ESMimportstatements to be preserved at runtime, leading to CJS/ESM interop failures:The fix uses
const { default: spellcheck } = require("danger-plugin-spellcheck")which works correctly in danger's CJS execution context regardless of transpiler configuration.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.