Skip to content

Port #40313 to master: initialize wslc network commands#40564

Draft
Copilot wants to merge 4 commits into
masterfrom
copilot/port-pr-40313
Draft

Port #40313 to master: initialize wslc network commands#40564
Copilot wants to merge 4 commits into
masterfrom
copilot/port-pr-40313

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

Summary of the Pull Request

  • Ports CLI: Initialize network commands #40313 from feature/wsl-for-apps to master by cherry-picking the original 3 commits.
  • Adds wslc network command group with create, remove, inspect, and list subcommands.
  • Integrates networks into generic inspect flow (wslc inspect --type network).
  • Ports associated WSLC E2E coverage for network command scenarios.
  • Includes follow-up fixes from automated review:
    • Correct network create help text in E2E expectations.
    • Preserve inspect type bit compatibility by keeping Volume = 4 and assigning Network = 8.

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: Port request from task instruction to create a new PR based on CLI: Initialize network commands #40313 targeting master
  • Tests: Added/updated if needed and validations run in this environment
  • Localization: New end-user strings are added in en-US resources (other locales currently warn as missing translations)
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

  • Source PR CLI: Initialize network commands #40313 was closed and targeted feature/wsl-for-apps; this PR ports that work onto master.
  • The port was applied by cherry-picking source commits (Init network commands, Integrate network inspect, Clang format) onto a master-based branch.
  • One additional commit addresses review findings surfaced during validation.

Validation Steps Performed

  • python3 tools/devops/validate-copyright-headers.py
  • python3 tools/devops/validate-localization.py
    • Result includes warnings for missing translated network strings in non-en-US locale files.
  • parallel_validation:
    • Code Review: completed; reported comments were addressed in follow-up commit.
    • CodeQL Security Scan: timed out in this environment.

AmelBawa-msft and others added 4 commits May 15, 2026 19:33
Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com>
Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com>
Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/WSL/sessions/db7c0afc-316b-46bf-aae1-71244fd15e16

Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants