plan9: re-enable virtio9p now that the known virtio queue corruption issue has been root caused#40600
Draft
benhillis wants to merge 1 commit into
Draft
plan9: re-enable virtio9p now that the known virtio queue corruption issue has been root caused#40600benhillis wants to merge 1 commit into
benhillis wants to merge 1 commit into
Conversation
…issue has been root caused
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Re-enables the virtio9p backend for Plan9 by flipping the default config flag, removing the forced disable + user warning, and restoring the corresponding test class.
Changes:
- Default
EnableVirtio9pset totrueand the override that forced it off (with user warning) removed. - Removed the now-unused
MessageConfigVirtio9pDisabledlocalization string. - Re-enabled the
Virtio9pDrvFs test class.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/windows/common/WslCoreConfig.h | Default EnableVirtio9p changed from false to true. |
| src/windows/common/WslCoreConfig.cpp | Removed forced-disable block and user warning emission. |
| localization/strings/en-US/Resources.resw | Removed the now-unused MessageConfigVirtio9pDisabled string. |
| test/windows/DrvFsTests.cpp | Re-enabled the Virtio9p DrvFs test class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan9 with the virtio backend was disabled some time ago, but I believe the issue that was causing the reported issue has been root caused and resolved, so it should now be safe to re-enabled. Submitting the PR as a draft for now while I collect some perf measurements and run tests.