[WinAppSDK CMake Support]: Implicitly choose deployment mode based on WindowsAppSDKSelfContained#6490
Draft
ssparach wants to merge 2 commits into
Draft
[WinAppSDK CMake Support]: Implicitly choose deployment mode based on WindowsAppSDKSelfContained#6490ssparach wants to merge 2 commits into
ssparach wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes to the embedded CMake to abide by the refinements introduced where a consuming application no longer needs to link against _Framework or _SelfContained targets accordingly and instead needs to set a property i.e. WindowsAppSDKSelfCOntianed (similar to MSBuild).
The embedded config will then be responsible to call the helper that will resolve to the right target for the consumer. This PR also contains changes to the appxmanifest generation flow.
To examine the consumption model, please see samples inside draft PR: microsoft/WindowsAppSDK-Samples#636 . Note, these samples will only be merged to the public sample repository once users have access to these changes i.e. the changes have been shipped.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.