Skip to content

[dotnet-code] Split workflow output filter internals #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Michelle Clayton (michelle-clayton-work) wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

[dotnet-code] Split workflow output filter internals #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions workflow/inproc/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,10 +616,10 @@ func (proc *runnerContext) yieldOutput(ctx context.Context, executorID string, o
return fmt.Errorf("executor %q cannot output object of type %s; expected one of %v", executorID, reflect.TypeOf(output), expectedTypes)
}

tags, ok := proc.outputFilter.tryGetTags(executorID)
if !ok {
if !proc.outputFilter.canOutput(executorID, output) {
return nil
}
tags, _ := proc.outputFilter.tryGetTags(executorID)
Comment on lines +619 to +622
return proc.addEvent(ctx, workflow.OutputEvent{
ExecutorID: executorID,
Output: output,
Expand Down
8 changes: 8 additions & 0 deletions workflow/inproc/outputfilter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ func newOutputFilter(wf *workflow.Workflow) *outputFilter {
return &outputFilter{tagsByExecutor: wf.OutputExecutors()}
}

func (f *outputFilter) canOutput(executorID string, _ any) bool {
if f == nil {
return false
}
_, ok := f.tagsByExecutor[executorID]
return ok
}

func (f *outputFilter) tryGetTags(executorID string) ([]workflow.OutputTag, bool) {
if f == nil {
return nil, false
Expand Down