Fix PR classifier label permissions - #840
Queued
Michelle Clayton (michelle-clayton-work) wants to merge 2 commits into
Queued
Fix PR classifier label permissions#840Michelle Clayton (michelle-clayton-work) wants to merge 2 commits into
Michelle Clayton (michelle-clayton-work) wants to merge 2 commits into
Conversation
Michelle Clayton (michelle-clayton-work)
requested a review
from a team
as a code owner
August 13, 2026 19:09
Copilot started reviewing on behalf of
Michelle Clayton (michelle-clayton-work)
August 13, 2026 19:09
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the pull-request classification workflow to correctly apply labels by granting the required pull-requests: write permission, and aligns workflow-dispatch PR number handling with reusable workflow numeric input expectations.
Changes:
- Grant
pull-requests: writeat both workflow and reusable-workflow job levels to allow label application. - Pin both reusable classifier workflows to the referenced go-infra fix commit.
- Ensure workflow-dispatch
pr-numberis passed as a number viafromJSON(github.event.inputs.pr-number || '0'), and adjust the dispatch guard to compare against'0'.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
George Adams (gdams)
approved these changes
Aug 14, 2026
George Adams (gdams)
enabled auto-merge
August 14, 2026 09:40
George Adams (gdams)
added this pull request to the merge queue
Aug 14, 2026
Any commits made after this event will not be merged.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 14, 2026
George Adams (gdams)
added this pull request to the merge queue
Aug 14, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull-requests: writeGitHub authorizes adding a label to a pull request through the
pull-requestspermission, even though the REST route is/issues/{number}/labels. Production run https://github.com/microsoft/agent-framework-go/actions/runs/31719034436 hadIssues: writebut onlyPullRequests: read, so every label POST returned403 Resource not accessible by integration.The first validation dispatch also exposed that the caller's logical-OR expression converted the numeric dispatch input into an invalid reusable-workflow value.
fromJSON(github.event.inputs.pr-number)preserves the required number type.Depends on microsoft/go-infra#545.
Validation
.github/workflows/classify-pull-request.ymlPullRequests: writeand appliedsize:mediumplusarea:agentto PR [dotnet-port-fixes] Bound tool approval auto-approval loop #835kind:codeandkind:testsBootstrap check
The automatic classifier check on this PR is expected to reproduce the existing
403until this caller fix reachesmain:pull_request_targetalways loads the workflow definition from the default branch rather than from the pull request. The branch-basedworkflow_dispatchvalidation above exercised this exact diff and passed end to end.