[BREAKING] Python: Ensure session isolation for FHA invocation impl#7158
Open
TaoChenOSU wants to merge 2 commits into
Open
[BREAKING] Python: Ensure session isolation for FHA invocation impl#7158TaoChenOSU wants to merge 2 commits into
TaoChenOSU wants to merge 2 commits into
Conversation
TaoChenOSU
added
python
github-actions
Bot
changed the title
giles17
added
the
documentation
Contributor
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Python Foundry Hosted Agents Invocations hosting implementation to derive session partitioning from the Foundry request context (session/user IDs) to improve session isolation in hosted scenarios, and adds tests and sample documentation updates around invocations + streaming.
Changes:
- Add
_partition_key()to compute a session cache key using Foundry request context (and fail fast when hosted protocol context is missing). - Update
_handle_invoke()to key the in-memory session cache by the partition key rather thanrequest.state.session_id. - Add unit + integration tests for invocations, and update the basic invocations sample README with a streaming curl example.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| python/samples/04-hosting/foundry-hosted-agents/invocations/01_basic/README.md | Documents a streaming invocation example alongside the existing non-streaming example. |
| python/packages/foundry_hosting/agent_framework_foundry_hosting/_invocations.py | Introduces partition-key session isolation based on Foundry request context; updates invocation handler behavior. |
| python/packages/foundry_hosting/tests/test_invocations.py | Adds unit tests covering partition-key behavior and invocation handler behavior (streaming/non-streaming). |
| python/packages/foundry_hosting/tests/test_invocations_int.py | Adds integration tests exercising the ASGI pipeline against a real Foundry endpoint (skipped unless env vars are provided). |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
TaoChenOSU
changed the title
giles17
added
the
breaking change
TaoChenOSU
marked this pull request as ready for review
July 16, 2026 18:46
| context = get_request_context() | ||
|
|
||
| # Fail fast if the service is on protocol v1.0.0 | ||
| if self.config.is_hosted and context.call_id is None: |
Member
There was a problem hiding this comment.
how does this determine the version, is call_id new for protocol v2?
| raise RuntimeError( | ||
| "The hosted environment is running on protocol 1.0.0, but the agent requires protocol 2.0.0. " | ||
| "Please upgrade your agent protocol to 2.0.0 in `agent.manifest.yaml` or `agent.yaml`, or " | ||
| "downgrade the `agent-framework-foundry-hosting` package to `1.0.0a260625` or before to use 1.0.0." |
Member
There was a problem hiding this comment.
is this even an option?
| "The hosted environment is missing session_id or user_id in the request context. " | ||
| "Please ensure that the request is coming from a valid Foundry platform service." | ||
| ) | ||
| return f"{context.session_id}:{context.user_id}" |
Member
There was a problem hiding this comment.
is the format for this agreed upon?
| return StreamingResponse(content=error, status_code=400) | ||
| return Response(content=error, status_code=400) | ||
|
|
||
| session = self._sessions.setdefault(session_id, AgentSession(session_id=session_id)) |
Member
There was a problem hiding this comment.
what happens when the server stops? are these preserved?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Currently, the light-weight Foundry Hosting Agent (FHA) invocation integration stores live AgentSession objects in a process-wide dictionary keyed only by the
session_id, which could potentially allow cross-user invocation.Description & Review Guide
This PR ensures that the sessions are key by the user id injected by the platform when the agent is hosted in FHA., eliminating the possibility that one user can interfere with another user's session even if the session id is exposed.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.