fix(prune): preserve case-equivalent GitHub dependencies - #3158
Open
Shaurya Saria (icecold009) wants to merge 1 commit into
Open
Shaurya Saria (icecold009) wants to merge 1 commit into
Shaurya Saria (icecold009) wants to merge 1 commit into
Conversation
Shaurya Saria (icecold009)
requested review from
Daniel Meppiel (danielmeppiel) and
Sergio Sisternes (sergio-sisternes-epam)
as code owners
October 3, 2026 09:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After installing
microsoft/apm, changing the manifest toMicrosoft/APMcould makeapm prunedelete that still-declared package. Prune now recognizes its existing case-equivalent materialization while preserving the actual directory spelling.This opts only prune into the existing host-aware materialization matcher. Direct and lockfile-retained transitive dependencies use the same comparison. Aliases, local packages, case-sensitive hosts and in-repository path casing keep their existing rules. Ambiguous case variants fail before cleanup. No rename or global lowercasing is introduced.
Issue and approved scope
Fixes #3034.
Human approval: #3034 (comment)
Coordination comment: #3034 (comment)
Completes the approved scope: dependency preservation, actual orphan removal, host-sensitive regressions and directly related prune documentation. Review contact: Daniel Meppiel (@danielmeppiel).
Type of change
Testing
Exact head:
c347ee3d5dbea58b2ad984b90af96d5559d536af, based on18c4c43c924ceae890fe0f2038806690e5b2d6c8.Clean
uv sync --frozen --extra devenvironment, Python 3.12.14; Ruff 0.15.12 matches the lockfile.tests/qualityandtests/spec_conformance/test_lockfile_reqs.py: 100 passed, 1 skipped.uv build --no-build-isolationbuilt the source distribution and wheel.git diff --checkpassed.The CLI cases use the canonical
apm_engine_commandfixture, shared lifecycle runner and isolated environment with networking disabled. They execute the source-installed CLI; frozen-binary and remote-CI results are not claimed.Scenario evidence
AI disclosure: Codex generated this patch and performed the checks above. Jev
jev-1.13.0reviewed the complete six-file diff with no exclusions and no clear issue; advisory review does not replace maintainer review.Spec conformance (OpenAPM v0.1)
No normative requirement is amended. This restores existing host-aware identity behavior; the existing lockfile conformance suite passed as part of the validation above.