[do not review] chore(shim): Update shim-unsigned-* to 16.1 - #18474
Draft
Lynsey Rydberg (corvus-callidus) wants to merge 4 commits into
Draft
[do not review] chore(shim): Update shim-unsigned-* to 16.1#18474Lynsey Rydberg (corvus-callidus) wants to merge 4 commits into
Lynsey Rydberg (corvus-callidus) wants to merge 4 commits into
Conversation
Replace the Fedora Secure Boot CA with the Azure Linux CA in both unsigned shim packages.
Lynsey Rydberg (corvus-callidus)
requested a review
from a team
as a code owner
August 17, 2026 20:14
Lynsey Rydberg (corvus-callidus)
marked this pull request as draft
August 17, 2026 20:14
Contributor
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
|
Hello, and thank you for opening this pull request! 👋🏼 We appreciate the contribution. We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Commits in this repo will typically be prefixed with Details: |
Copilot started reviewing on behalf of
Lynsey Rydberg (corvus-callidus)
August 17, 2026 20:16
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates x64 and aarch64 unsigned shim packages from 15.8 to 16.1 and adds Azure Linux Secure Boot/SBAT customization.
Changes:
- Pins updated Fedora shim sources and refreshes locks.
- Adds Azure Linux certificate and SBAT records.
- Removes unsupported IA32 output from x64.
Reviewed changes
Copilot reviewed 10 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/shim-unsigned-x64/shim-unsigned-x64.comp.toml |
Defines x64 pin and overlays. |
base/comps/shim-unsigned-aarch64/shim-unsigned-aarch64.comp.toml |
Defines aarch64 pin and overlays. |
locks/shim-unsigned-x64.lock |
Locks updated x64 source. |
locks/shim-unsigned-aarch64.lock |
Locks updated aarch64 source. |
specs/s/shim-unsigned-x64/sources |
Records 16.1 source checksum. |
specs/s/shim-unsigned-x64/shim-unsigned-x64.spec |
Renders x64 package changes. |
specs/s/shim-unsigned-x64/sbat.redhat.csv |
Removes obsolete static SBAT data. |
specs/s/shim-unsigned-x64/sbat.azurelinux.csv.in |
Adds templated x64 SBAT data. |
specs/s/shim-unsigned-aarch64/sources |
Records 16.1 source checksum. |
specs/s/shim-unsigned-aarch64/shim-unsigned-aarch64.spec |
Renders aarch64 package changes. |
specs/s/shim-unsigned-aarch64/sbat.redhat.csv |
Removes obsolete static SBAT data. |
specs/s/shim-unsigned-aarch64/sbat.azurelinux.csv.in |
Adds templated aarch64 SBAT data. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| [components.shim-unsigned-x64] | ||
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "bacb81905ea6806b97b968527e5ca9b2e3f0f7b4" } | ||
| # Pin shim 16.1 to Fedora dist-git commit d355c62164bd48c6f47774fe04b0d730d892e006. | ||
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d355c62164bd48c6f47774fe04b0d730d892e006" } |
Contributor
Author
There was a problem hiding this comment.
This is intentional. We'll update the shim package once we have properly signed 16.1 binaries.
| [components.shim-unsigned-aarch64] | ||
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "67c1d520f9a8080f6b689714099f813f23154c8f" } | ||
| # Pin shim 16.1 to Fedora dist-git commit 4db14e5ed7d3bdb7fda97f62c93e612435f2cce9. | ||
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "44" }, upstream-commit = "4db14e5ed7d3bdb7fda97f62c93e612435f2cce9" } |
Contributor
Author
There was a problem hiding this comment.
This is intentional. We'll update the shim package once we have signed 16.1 binaries.
Comment on lines
+15
to
+22
| { type = "spec-remove-subpackage", package = "shim-unsigned-%{efialtarch}" }, | ||
| { type = "spec-remove-subpackage", package = "shim-unsigned-%{efialtarch}-debuginfo" }, | ||
| { type = "spec-search-replace", regex = '^%global __debug_install_post %{SOURCE100} %{efiarch} %{efialtarch}$', replacement = "%global __debug_install_post %{SOURCE100} %{efiarch}" }, | ||
| { type = "spec-search-replace", section = "%prep", regex = '^mkdir build-%{efialtarch}$', replacement = "" }, | ||
| { type = "spec-search-replace", section = "%build", regex = '^cd build-%{efialtarch}$', replacement = "%if 0\ncd build-%{efialtarch}" }, | ||
| { type = "spec-append-lines", section = "%build", lines = ["%endif"] }, | ||
| { type = "spec-search-replace", section = "%install", regex = '^cd build-%{efialtarch}$', replacement = "%if 0\ncd build-%{efialtarch}" }, | ||
| { type = "spec-append-lines", section = "%install", lines = ["%endif", "ln -s %{version}-%{release} %{buildroot}%{_datadir}/shim/%{version}-2"] }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.