fix(rust-openssl): backport re-mint of expired X.509 test fixtures - #18480
Open
Thien Trung Vuong (trungams) wants to merge 1 commit into
Open
fix(rust-openssl): backport re-mint of expired X.509 test fixtures#18480Thien Trung Vuong (trungams) wants to merge 1 commit into
Thien Trung Vuong (trungams) wants to merge 1 commit into
Conversation
The bundled test fixtures (leaf/intermediate-ca expired 2026-08-11, cert/root-ca 2026-08-12) make x509::tests::test_set_purpose and x509::tests::test_verify_param_set_depth fail in %check on any build after those dates. Backport upstream sfackler/rust-openssl commit 10bbf71 (PR #2669) which re-issues all four certs with notAfter moved to 2037-12-31 and updates the derived fingerprint/signature/notAfter assertions. Move rust-openssl to a dedicated comp.toml so the overlay is discovered.
Copilot started reviewing on behalf of
Thien Trung Vuong (trungams)
August 18, 2026 00:08
View session
Member
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the upstream rust-openssl fix for expired X.509 test fixtures, restoring %check reliability.
Changes:
- Adds the upstream fixture-renewal patch through an overlay.
- Refreshes the lock and generated spec output.
- Moves rust-openssl into a dedicated component definition.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/components.toml |
Removes the inline component entry. |
base/comps/rust-openssl/rust-openssl.comp.toml |
Adds the dedicated component definition. |
base/comps/rust-openssl/overlays/0001-remint-expired-x509-test-fixtures.overlay.toml |
Configures and documents the backport. |
base/comps/rust-openssl/0001-Re-mint-expired-X.509-test-fixtures.patch |
Contains the upstream patch. |
locks/rust-openssl.lock |
Refreshes the component fingerprint. |
specs/r/rust-openssl/rust-openssl.spec |
Registers the patch and updates release metadata. |
specs/r/rust-openssl/0001-Re-mint-expired-X.509-test-fixtures.patch |
Adds the rendered patch artifact. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
reuben olinsky (reubeno)
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport upstream commit rust-openssl/rust-openssl@10bbf71 that re-mints expired X.509 test fixtures