fix(go-control-plane): update to 0.13.4 - #18508
Open
Mitch Zhu (miz060) wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prunes legacy Go dependency cycles and updates Envoy control plane to 0.13.4.
Changes:
- Removes unused Prometheus config-related packages and tests.
- Updates Envoy control plane source and version.
- Refreshes generated specs and component locks.
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
specs/g/golang-github-prometheus-common/golang-github-prometheus-common.spec |
Removes config packages. |
specs/g/golang-github-prometheus-client/golang-github-prometheus-client.spec |
Removes config-dependent example test. |
specs/g/golang-github-envoyproxy-control-plane/sources |
Adds the 0.13.4 archive checksum. |
specs/g/golang-github-envoyproxy-control-plane/golang-github-envoyproxy-control-plane.spec |
Updates the rendered version. |
locks/golang-github-prometheus-common.lock |
Refreshes the input fingerprint. |
locks/golang-github-prometheus-client.lock |
Refreshes the input fingerprint. |
locks/golang-github-envoyproxy-control-plane.lock |
Refreshes the input fingerprint. |
base/comps/golang-github-prometheus-common/overlays/0001-drop-unused-config-modules.overlay.toml |
Defines config-package pruning. |
base/comps/golang-github-prometheus-common/overlays/0001-add-missing-jmespath-buildrequires.overlay.toml |
Removes the obsolete dependency workaround. |
base/comps/golang-github-prometheus-client/overlays/0001-drop-pruned-config-example.overlay.toml |
Defines example-test pruning. |
base/comps/golang-github-prometheus-client/golang-github-prometheus-client.comp.toml |
Moves the customized component to a dedicated definition. |
base/comps/golang-github-envoyproxy-control-plane/overlays/0002-update-to-upstream-0.13.4.overlay.toml |
Defines the Envoy version update. |
base/comps/golang-github-envoyproxy-control-plane/golang-github-envoyproxy-control-plane.comp.toml |
Registers the new source archive. |
base/comps/components.toml |
Removes the now-customized client from the inline list. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Mitch Zhu (miz060)
force-pushed
the
mitchzhu/golang-dependency-cycle-pruning
branch
from
August 19, 2026 17:46
3183c19 to
b40da8c
Compare
Mitch Zhu (miz060)
marked this pull request as ready for review
August 19, 2026 17:50
Mitch Zhu (miz060)
force-pushed
the
mitchzhu/golang-dependency-cycle-pruning
branch
from
August 20, 2026 02:16
b40da8c to
93bcd6e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 14 changed files in this pull request and generated no new comments.
Suppressed comments (1)
specs/g/golang-github-envoyproxy-control-plane/sources:2
- The rendered source manifest now declares both the obsolete 0.11.1 archive and the 0.13.4 archive, even though the spec's
%{gosource}references only version 0.13.4. This leaves source preparation carrying an unused legacy input after the version bump. Please adjust the component's source handling and re-render so the manifest contains only the archive used by the spec.
SHA512 (go-control-plane-0.13.4.tar.gz) = c42791b0322bff372707b45ec140df2767e81c89a25e254622e088e6dcda86a4d6bf8384714c88e0deab34dd17f1f9a36ffa8c663a596885b02d8a24da2ec531
grpc-go's xDS packages require go-control-plane, but version 0.11.1 pulls deprecated OpenCensus APIs into a dependency cycle. Update to upstream 0.13.4, which removes those APIs while retaining the xDS capabilities grpc-go needs. Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
Mitch Zhu (miz060)
force-pushed
the
mitchzhu/golang-dependency-cycle-pruning
branch
from
August 20, 2026 02:40
93bcd6e to
a70a3e9
Compare
Mitch Zhu (miz060)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpc-go's xDS packages require go-control-plane, but version 0.11.1 pulls deprecated OpenCensus APIs into an unbuildable dependency cycle. Update to upstream 0.13.4, which removes those APIs while retaining the xDS capabilities grpc-go needs.
Validation:
%checkbody.