Pin GitHub Actions to full-length commit SHAs - #18518
Pin GitHub Actions to full-length commit SHAs#18518Dan Fiedler (danfiedler-msft) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Hello, and thank you for opening this pull request! 👋🏼 We appreciate the contribution. We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Commits in this repo will typically be prefixed with Details: |
There was a problem hiding this comment.
Pull request overview
Hardens GitHub Actions references by pinning two reusable workflows to a full commit SHA.
Changes:
- Replaces
4.0branch references with commit5c9b2dea…. - Retains version comments for reference.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/spec-review-stub.yml |
Pins the spec-review workflow. |
.github/workflows/check-rendered-specs-stub.yml |
Pins the rendered-specs workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # Intentionally branch-pinned to our own repo so the | ||
| # reusable workflow picks up prompt/script/agent updates automatically. | ||
| uses: microsoft/azurelinux/.github/workflows/spec-review.yml@4.0 # zizmor: ignore[unpinned-uses] | ||
| uses: microsoft/azurelinux/.github/workflows/spec-review.yml@5c9b2dea9bb17e0f9964fb4097426fc28215e21a # 4.0 |
| if: github.repository == 'microsoft/azurelinux' | ||
| # Intentionally branch-pinned so the reusable workflow picks up updates automatically. | ||
| uses: microsoft/azurelinux/.github/workflows/check-rendered-specs.yml@4.0 # zizmor: ignore[unpinned-uses] | ||
| uses: microsoft/azurelinux/.github/workflows/check-rendered-specs.yml@5c9b2dea9bb17e0f9964fb4097426fc28215e21a # 4.0 |
reuben olinsky (reubeno)
left a comment
There was a problem hiding this comment.
Dan Fiedler (@danfiedler-msft) Thanks for your contribution!
We're definitely fans of SHA-pinning github actions and had actually proactively enabled PR checks (via zizmor) to enforce that earlier this year. The notable exception are the actions in this repository that are referenced by this PR.
As the Copilot feedback on this PR calls out, this had been an intentional set-up so that the workflows in question will use the latest stable, already-merged versions of actions (from this repo) instead of anything changed as part of the PR itself.
We're open to some alternate approaches here but want to clarify that this had been intentional. Are there other approaches you'd recommend?
Summary
This PR pins GitHub Actions to full-length commit SHAs for improved security and reproducibility and adds a 7 day cooldown to Dependabot configuration for GitHub Actions. This work is described in more detail at https://aka.ms/action-pinning.
Why?
Pinning actions to commit SHAs prevents supply-chain attacks where a tag could be moved to point to malicious code. This is a recommended security best practice per the GitHub Actions security hardening guide.
This change mitigates the risk of tag retargeting to malicious code as seen in incidents like the tj-actions/changed-files action compromise or codfish/semantic-release-action compromise and improves the integrity and reproducibility of the CI/CD pipeline.
What changed?
Action pinning: Third-party action references in
.github/workflows/that used mutable tag-based references (e.g.,actions/checkout@v4) have been updated to full-length commit SHAs with a version comment (e.g.,actions/checkout@<sha> # v4) using the pinact tool. References that were already pinned to a SHA, or that used immutable release tags, were left unchanged.Dependabot configuration:
.github/dependabot.ymlhas been updated to ensure agithub-actionspackage-ecosystem section is present with acooldownconfiguration (default-days: 7). If the file did not exist, it was created. If agithub-actionssection already existed, only thecooldownblock was added or itsdefault-daysvalue was increased to 7 if it was lower. The 7-day cooldown provides a window for the community to detect and report compromised releases before they are automatically proposed as updates, reducing exposure to supply-chain attacks via newly published malicious versions.Is this safe to merge?
Yes. The pinned SHAs correspond to the same commits that the existing tags pointed to. No behavioral changes in action execution are introduced. You can verify the pinned SHA value using the GitHub REST API (e.g., the commit hash for
actions/checkout@v7can be found in theshaproperty in the JSON response forGET https://api.github.com/repos/actions/checkout/commits/v7).Additional Information
For more information, please see https://aka.ms/action-pinning