Backport memcached authentication token and binary protocol crash fixes - #18521
Open
Pawel Winogrodzki (PawelWMS) wants to merge 4 commits into
Open
Backport memcached authentication token and binary protocol crash fixes#18521Pawel Winogrodzki (PawelWMS) wants to merge 4 commits into
Pawel Winogrodzki (PawelWMS) wants to merge 4 commits into
Conversation
Backport the upstream authentication token size limit and regression test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 136058a7-d42e-48e7-831b-56453b23dacf
microsoft-github-policy-service
Bot
added
Packaging
fasttrack/3.0
Pawel Winogrodzki (PawelWMS)
marked this pull request as ready for review
August 19, 2026 23:11
Backport the upstream binary protocol mutation logging fix from Azure Linux pull request 18459 so a failed binary store no longer dereferences a missing item. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 136058a7-d42e-48e7-831b-56453b23dacf
Pawel Winogrodzki (PawelWMS)
changed the title
Chris Gunn (cwize1)
approved these changes
Aug 20, 2026
Match the upstream reference convention used by the binary protocol patch.
…atch Name the patch file consistently with the other memcached patches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
9981d748f866e80a8f2ee1b12bf45717f9595df9to reject oversized ASCII authentication tokens before calculating the remaining read length.32ea7d8b5b5c4ed516853a5668c6a2ca9f2b66f1so mutation logging no longer dereferences a missing item after a failed binary protocol store. This patch comes from memcached: apply patch: fix crash in binary protocol #18459.Validation
memcached-1.6.27-6RPM in an Azure Linux 3.0 build root and completed the package%checksuite successfully./usr/bin/memcachedbinary.--fuzz=0in the order declared by the spec file.Risk
fasttrack/3.0if both fixes ship together; otherwise revert the second commit and let that pull request proceed on its own.Note: #18459 targets
3.0-devand also used release 6 withPatch5. Here the authentication fix already holds release 6 andPatch5, so the binary protocol patch is registered asPatch6with a second bullet under the existing changelog entry.