gawk: drop sudo/shadow-utils BuildRequires to fix toolchain graph cycle - #18529
Open
jslobodzian wants to merge 5 commits into
Open
gawk: drop sudo/shadow-utils BuildRequires to fix toolchain graph cycle#18529jslobodzian wants to merge 5 commits into
jslobodzian wants to merge 5 commits into
Conversation
Revert the %check section to its 5.2.2-1 form. gawk is a toolchain bootstrap package; the sudo + shadow-utils BuildRequires added in 5.2.2-2 created an unresolvable dependency-graph cycle, breaking all check-enabled source builds (e.g. every buddy build). CVE patches are unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
Packaging
fasttrack/3.0
Kanishk Bansal (Kanishk-Bansal)
approved these changes
Aug 20, 2026
Kanishk Bansal (Kanishk-Bansal)
left a comment
Kanishk Bansal (Kanishk-Bansal)
left a comment
There was a problem hiding this comment.
un resolvable dependency of gawk on glibc , hence reverting this test changes for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the
%checksection ofSPECS/gawk/gawk.specto its 5.2.2-1 form and drops thesudo+shadow-utilsBuildRequiresadded in 5.2.2-2 (#18426). CVE patches (CVE-2026-40467/40468/40553) are unchanged. Release2 → 3.Why
gawk is a toolchain/bootstrap package and previously had no
BuildRequires. 5.2.2-2 added, under%if 0%{?with_check},BuildRequires: shadow-utils+sudoso the pma test could run as a non-root user. Underwith_check=1this expands gawk's build closure intosudo/shadow-utils→ glibc(/sbin/ldconfig) → gawk, forming an unresolvable dependency-graph cycle the grapher cannot break with prebuilt/PMC RPMs. It panics during full-graph generation (graph.dot), before any package is selected:PANI[grapher] unfixable circular dependency ... gawk-5.2.2-2 ... /sbin/ldconfig make: *** [pkggen.mk:150: .../graph.dot] Error 2Because the panic is in whole-repo graph construction, it breaks every check-enabled source build regardless of the package being built — e.g. ~100% of buddy builds since 08-17 (any target: flannel, golang, packer, expat, kubevirt, gh…).
Not affected: PMC consumers of the binary RPM, Fast-Track PROD (built/published gawk fine with checks off at graph time), and the DEV RPM cascade.
Fix
Restore the
-1%check(run the suite directly) and remove the twoBuildRequires. Trade-off: the pma persistent-memory test is skipped when the suite runs as root (check_pma_security()refuses persistent memory for euid 0) — same coverage as-1and every prior release.Follow-up
3.0-dev(also carries the poisoned spec).runuser(util-linux, already in base) instead ofuseradd+sudo, avoiding the toolchain build-dep.