Skip to content

Updated endpoints for China region#178

Merged
terencet-dev merged 5 commits into
mainfrom
ttruong/new-endpoints-update
Apr 1, 2025
Merged

Updated endpoints for China region#178
terencet-dev merged 5 commits into
mainfrom
ttruong/new-endpoints-update

Conversation

@terencet-dev

Copy link
Copy Markdown
Contributor

Updated the endpoints table to include new endpoints for the China region.

Signed-off-by: Terence Truong <Terence.Truong@microsoft.com>
Signed-off-by: Terence Truong <Terence.Truong@microsoft.com>
Signed-off-by: Terence Truong <Terence.Truong@microsoft.com>
@terencet-dev

Copy link
Copy Markdown
Contributor Author

This also includes the fix for: #173

Comment thread docs/client-firewall-rules.md Outdated
Comment thread docs/mcr-endpoints-guidance.md Outdated

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions.

Signed-off-by: Terence Truong <Terence.Truong@microsoft.com>
Comment thread docs/mcr-endpoints-guidance.md Outdated
Comment on lines +45 to +46
- North China
- East China

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- North China
- East China
- China North 3
- China East 3

See naming in below links:

qweeah
qweeah previously approved these changes Mar 31, 2025

@qweeah qweeah left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions

Signed-off-by: Terence Truong <Terence.Truong@microsoft.com>

@qweeah qweeah left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants