fix: ensure non-TTY agents dont hang - #172
Conversation
| @@ -34,6 +34,7 @@ program | |||
| .option('--quiet', 'do not ask for interactive input prompts') | |||
| .option('--gha', 'install GitHub Actions') | |||
There was a problem hiding this comment.
Simon Knott (@Skn0tt) I think there's still not a --no-gha flag for non-interactive rejection of GitHub Actions workflow files, as I mentioned here:
There was a problem hiding this comment.
I don't think that's needed, GitHub Actions workflow files are off unless --gha is passed. So --no-gha is the default.
There was a problem hiding this comment.
that requires the --quiet flag, which hides the defaults
it's less obvious what this does:
pnpm create playwright --browser=chromium --test-dir=playwright --quietit would be easier to understand if you can just exhaustively pass in all options (this would break after your PR):
pnpm create playwright --browser=chromium --test-dir=playwright --no-ghawe're getting into the same conversation territory in the new PR, so I'll continue over here:
There was a problem hiding this comment.
The original issues #39986 and #39987 weren't actually resolved by this PR
There may be an option to complete this over here:
3 participants
Closes microsoft/playwright#39986:
createFilesfrom hanging in quiet mode--test-dirflag, which was only configurable interactively before