fix(vr-tests-web-components): update test scripts and fix story errors - #35475
Merged
Dmytro Kirpa (dmytrokirpa) merged 1 commit intoNov 15, 2025
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Dmytro Kirpa (dmytrokirpa)
marked this pull request as ready for review
November 11, 2025 11:30
3 tasks
Victor Genaev (mainframev)
approved these changes
Nov 11, 2025
Dmytro Kirpa (dmytrokirpa)
enabled auto-merge (squash)
November 11, 2025 13:34
Contributor
Author
|
Could I get a review for this one, please, @microsoft/fui-wc? |
Dave Rupert (davatron5000)
approved these changes
Nov 14, 2025
Dmytro Kirpa (dmytrokirpa)
disabled auto-merge
November 14, 2025 17:09
Dmytro Kirpa (dmytrokirpa)
merged commit Nov 15, 2025
6cbe729
into
microsoft:master
12 checks passed
Dmytro Kirpa (dmytrokirpa)
deleted the
fix/vr-tests-web-components/bail-on-stories-error
branch
November 15, 2025 09:09
Tudor Popa (tudorpopams)
pushed a commit
to tudorpopams/fluentui
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We found in #35346 (comment) that some WebComponents VR tests were logging errors quietly without causing the pipeline to fail.
New Behavior
--bailOnStoriesErrorflag to thetest-vrscript in package.json for improved error handling.Array.fromasHTMLCollectiondoesn't haveforEachmethodidattribute to the long text link story for proper element targeting.aria-haspopupattributes.fluent-radioselectors for as there are no elements with the[role=radio]attributefluent-sliderinstead of[role="slider"]as there are no elements such elementsRelated Issue(s)
--bailOnStoriesErrorparam tovr-testsandvr-tests-web-components#35430