Skip to content

fix(react-headless-components-preview): default aria-hidden on NavCategoryItem's expandIcon slot #36690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ray Knight (ArrayKnight) wants to merge 1 commit into
base: master
Choose a base branch
from
+38 −0
Open

fix(react-headless-components-preview): default aria-hidden on NavCategoryItem's expandIcon slot #36690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-headless-components-preview-e4e832ae-9516-48ff-bcdb-4c477a4cc4d8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: default aria-hidden on NavCategoryItem's expandIcon slot",
"packageName": "@fluentui/react-headless-components-preview",
"email": "array.knight@gmail.com",
"dependentChangeType": "patch"
}
30 changes: 30 additions & 0 deletions ...eact-components/react-headless-components-preview/library/src/components/Nav/Nav.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,4 +202,34 @@ describe('Nav', () => {
expect(link.tagName).toBe('A');
expect(link).toHaveAttribute('href', 'https://example.com');
});

it('hides NavCategoryItem expandIcon from assistive technology by default', () => {
const result = render(
<Nav>
<NavCategory value="cat1">
<NavCategoryItem expandIcon={{ children: <img alt="expand" src="chevron.png" /> }}>
Category 1
</NavCategoryItem>
</NavCategory>
</Nav>,
);

expect(result.getByRole('button', { name: 'Category 1' })).toBeInTheDocument();
expect(result.getByAltText('expand').parentElement).toHaveAttribute('aria-hidden', 'true');
});

it('allows a consumer to override NavCategoryItem expandIcon aria-hidden', () => {
const result = render(
<Nav>
<NavCategory value="cat1">
<NavCategoryItem expandIcon={{ 'aria-hidden': false, children: <img alt="expand" src="chevron.png" /> }}>
Category 1
</NavCategoryItem>
</NavCategory>
</Nav>,
);

expect(result.getByRole('button', { name: 'Category 1 expand' })).toBeInTheDocument();
expect(result.getByAltText('expand').parentElement).toHaveAttribute('aria-hidden', 'false');
});
});
1 change: 1 addition & 0 deletions ...dless-components-preview/library/src/components/Nav/NavCategoryItem/useNavCategoryItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export const useNavCategoryItem = (
elementType: 'span',
}),
expandIcon: slot.optional(expandIcon, {
defaultProps: { 'aria-hidden': true },
elementType: 'span',
}),
components: {
Expand Down